Cleanup runechat callbacks upon deletion #2236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! Less runtimes! |
|
this should also reduce memory usage too :) |
|
Sounds even better. |
Absolucy
force-pushed
the
runechat-runtime-cleanup
branch
from
df0cd94 to
2bdb131
Compare
Absolucy
force-pushed
the
runechat-runtime-cleanup
branch
from
2bdb131 to
d18f0a2
Compare
This was referenced Jun 14, 2024
This was referenced Jun 14, 2024
Closed
Closed
Closed
|
haven't seen any chatmessage runtimes since this was TM'd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Should get rid of one of the most common runtime errors that occurs.
Changelog
🆑
fix: Fixed a common runtime error relating to runechat messages and logged out clients.
/:cl: