Port several tgui-related fixes from /tg/ #2245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are several esoteric code paths that lead to `winexists` calls or sleeps in `ui_data`. This proc is meant to be a command without sleeping. See #75232 
…215) ## About The Pull Request Unused vars have 0 memory cost, and the ref and list lookup here is REALLY expensive, for both init and foam spreading. ## Why It's Good For The Game Saves 0.2s off a station flood on meta, and 0.17s off init. More time in other qdel heavy areas Pulled off #76104 for the sake of cleanliness
## About The Pull Request src_object is NOT guaranteed to be passed in. HHHHHHHHHHH Closes #76249
Fixes tgstation/tgstation#77097 This breaks uis for everyone with fancy-tgui off and in cases where the window is closed by external action (byond closing it) which is pretty bad.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Ports the following PRs:
No changelog due to no user-facing changes.