Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heretics can now sacrifice *any* head of staff for the objective. #2309

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

Absolucy
Copy link
Member

@Absolucy Absolucy commented Jun 17, 2024

Changelog

🆑
balance: Heretics can now sacrifice any head of staff, regardless of if they're a target or not, if they have the "sacrifice head of staff" objective, and have not completed it.
/:cl:

@F-e-r-n
Copy link
Collaborator

F-e-r-n commented Jul 7, 2024

Admin requested changes: Make it so you can only sacrifice non-target heads if you have the head objective, and make it only work if it has not been completed. This is to prevent players from completely ignoring their targets and just going after command. If you have any questions about this decision please bring it up with p_l_a_n_t on discord. -Syndie Kate

@Absolucy
Copy link
Member Author

Absolucy commented Jul 7, 2024

Make it so you can only sacrifice non-target heads if you have the head objective, and make it only work if it has not been completed

@F-e-r-n That is exactly how this PR does it.

@F-e-r-n
Copy link
Collaborator

F-e-r-n commented Jul 7, 2024

Make it so you can only sacrifice non-target heads if you have the head objective, and make it only work if it has not been completed

@F-e-r-n That is exactly how this PR does it.

guh i read the code at like midnight lemme reread it

@F-e-r-n
Copy link
Collaborator

F-e-r-n commented Jul 7, 2024

okay yeah, approved

@Absolucy Absolucy closed this Jul 25, 2024
@Absolucy Absolucy reopened this Jul 25, 2024
@dwasint dwasint merged commit b4c3958 into Monkestation:master Aug 2, 2024
41 checks passed
github-actions bot added a commit that referenced this pull request Aug 2, 2024
@Absolucy Absolucy deleted the heretic-sac-head branch August 2, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants