New plant trait and dank vescicles bug fix #2342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
. |
|
fixed, this PR is ready for merge |
ancient-engineer
suggested changes
Jul 1, 2024
Co-authored-by: ancient-engineer <[email protected]>
Co-authored-by: ancient-engineer <[email protected]>
Co-authored-by: ancient-engineer <[email protected]>
Co-authored-by: ancient-engineer <[email protected]>
Co-authored-by: ancient-engineer <[email protected]>
Co-authored-by: ancient-engineer <[email protected]>
Co-authored-by: ancient-engineer <[email protected]>
Co-authored-by: ancient-engineer <[email protected]>
|
@ancient-engineer solved your comments |
|
You cant really move the new plantgene disk to monkstation folder |
|
ready i guess |
wraith-54321
pushed a commit
to wraith-54321/Monkestation2.0
that referenced
this pull request
Aug 9, 2024
…ng, weapon, rite (#74811)  Adds a new chaplain weapon and suit of armor, the divine archer. It's an orderable set of armor, but provides less armor than the rest, but you get more pieces of armor (boots, bracer, undersuit). The divine bow comes with a quiver that holds holy arrows. The holy arrows come with bane support, dealing critical damage to revenants. - arrows can now be dipped in poison - bows now drop their arrow when you put them on your back while nocking a bow - bows give feedback for trying to draw without a nocked arrow - codewise, bows support subtypes much better. They still have hard-sprited loaded arrows, but one day that'll change. Yeah, we could add null rod Monkestation#2342 that does almost the same as the others, or we could have a unique bow weapon! Player Dev Project thread: https://discord.com/channels/326822144233439242/1093521091957370940/1093521091957370940 🆑 tralezab code, Drag for the commission and player project, cre#0484 for their spritework add: Divine Archer Armor and Weapon qol: Bows give more feedback when you're doing something wrong, like trying to draw without a nocked arrow code: Sorted files, cleaned bow code up to allow subtypes /:cl:
Done |
Absolucy
requested changes
Sep 20, 2024
| @@ -426,6 +426,10 @@ | |||
| var/read_only = 0 //Well, it's still a floppy disk | |||
| obj_flags = UNIQUE_RENAME | |||
|
|
|||
| /obj/item/disk/plantgene/syndicate // Monkestation item | |||
| gene = new /datum/plant_gene/trait/noreact | |||
| read_only = 1 | |||
There was a problem hiding this comment.
Suggested change
| read_only = 1 | |
| read_only = TRUE |
| @@ -426,6 +426,10 @@ | |||
| var/read_only = 0 //Well, it's still a floppy disk | |||
There was a problem hiding this comment.
Suggested change
| var/read_only = 0 //Well, it's still a floppy disk | |
| var/read_only = FALSE //Well, it's still a floppy disk |
fix this while ya here i guess
| @@ -63,3 +63,11 @@ | |||
| pod.custom_objective = objective | |||
| pod.RefreshParts() | |||
| pod.locked = TRUE // The pod shouldn't be eligible for cloner event. | |||
|
|
|||
| /datum/uplink_item/role_restricted/syndicate_plant_gene | |||
There was a problem hiding this comment.
this is silly, but can you move this further up in the file, so I can TM this without conflicts?
|
fuck it we ball |
Absolucy
added a commit
to Absolucy/Monkestation
that referenced
this pull request
Sep 20, 2024
Based, first server to bring back separated chems, monkestation making history |
|
this cannot possibly go wrong |
I mean, it's 20 telecrystals, job gated and monkestation rules don't really allow someone to go around and make the station unhabitable with tomatos, it's fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
adds a new plat gene trait called Catalytic Inhibitor Serum only available in the traitor uplink for 20tc, fixes a bug with dank vesciles and densified chemicals interaction, densified chemicals sometimes overrided dank vesciles and when it did not override, it was not properly multiplying the max volume by 2
EDIT: removed the potency limiter gene because it was literaly doing nothing(buged) but causing any plant with densified chemicals to have limited potency instead(buged), i dont believe there is a reason for that gene to exist right now
Why It's Good For The Game
Bug fix about an expected behavior, and adds new powerful trait gated by antagonist role for 20tc in the uplink, if you see a botanicist blowing stuff up with potwat reaction then he is valid.
Changelog
🆑
add: new plant trait catalytic inhibitor serum
add: new job restricted traitor uplink item, plant data disk with catalytic inhibitor serum gene for 20tc
fix: fixed Dank Vesicles and densified chemicals interaction
remove: potency limiter gene
code: potency limiter gene code removed
🆑