-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintenance God Glow Up #2347
Maintenance God Glow Up #2347
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MaintenanceEncyclopedia.dm should not be capitalized
Yup, it's not capitalized on my computer but git decided to be yucky |
Classic git |
Git decided to be yucky and ignore my earlier change.
I wanted to give shadowpeople darkness reviving like nightmares do, but I was afraid it would be too op. |
This reverts commit cccdb02.
@@ -74,6 +74,14 @@ | |||
build_path = /obj/item/food/monkeycube | |||
category = list(RND_CATEGORY_INITIAL, RND_CATEGORY_BIO_FOOD) | |||
|
|||
/datum/design/rat_cube // Monkestation, useful for chaplain and pathologist. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be in the modular directory
name = "maintenance encyclopedia" | ||
icon_state = "book1" | ||
desc = "A burnt and damaged tome? Where did this come from?" | ||
crafting_recipe_types = list( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think instead of just giving all of them it should pick 1 you dont already have to randomly give
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would the best way to do this? Are there any examples of this from other granters?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
something like uh
var/static/list/possible_recipes = [this list here]
and then on init do
crafting_recipe_types = list(pick(possible_recipes))
might also want to add a check for if they already know the recipe or not
invoke_msg = "I no longer want to see the light!" | ||
favor_cost = 300 | ||
|
||
/datum/religion_rites/shadowascension/perform_rite(mob/living/user, atom/religious_tool) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add some spacing to all the things here to make them more readable
About The Pull Request
Makes the maintenance god sect much more viable and interesting.
Why It's Good For The Game
The maintenance sect as of now is extremely boring. You have a difficult time looking for rats (that might already be cleaned from maintenance.) All so you can buy rituals that hurt you more then they help you.
This gives more utility to the maintenance sect, and makes the downsides less punishing.
Changelog
🆑
add: Added three new rituals to the maintenance sect.
del: Removes adapted eyes ritual from maintenance sect. (Replaced by shadow person ascension.)
balance: Maintenance Sect is now better.
balance: Maintenance drugs addiction less punishing.
/:cl: