Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance God Glow Up #2347

Merged
merged 21 commits into from
Aug 12, 2024
Merged

Maintenance God Glow Up #2347

merged 21 commits into from
Aug 12, 2024

Conversation

Uristthedorf
Copy link
Contributor

@Uristthedorf Uristthedorf commented Jun 21, 2024

About The Pull Request

Makes the maintenance god sect much more viable and interesting.

  • Maintenance drug addiction has less severe effects, now doesn't stop you from telling your own health, and expands your pallet of food a bit. (You can now eat raw rats just fine.)
  • Replaces the adapted eyes ritual with a shadow ascension ritual, which turns you into a shadowperson.
  • Two other new rituals, one that gives a granter for crafting recipes (elite version of maint guns and trash cannon.) Another that spawns 5 random uncommon or rarer maintenance loot items. (Useful for when maintenance has already been picked clean of interesting loot.)
  • Rat cubes are now easier to get, being cheaper at cargo with no access requirement, and being printable from biogenerator.

Why It's Good For The Game

The maintenance sect as of now is extremely boring. You have a difficult time looking for rats (that might already be cleaned from maintenance.) All so you can buy rituals that hurt you more then they help you.
This gives more utility to the maintenance sect, and makes the downsides less punishing.

Changelog

🆑
add: Added three new rituals to the maintenance sect.
del: Removes adapted eyes ritual from maintenance sect. (Replaced by shadow person ascension.)
balance: Maintenance Sect is now better.
balance: Maintenance drugs addiction less punishing.
/:cl:

Copy link
Contributor

@ancient-engineer ancient-engineer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MaintenanceEncyclopedia.dm should not be capitalized

@Uristthedorf
Copy link
Contributor Author

MaintenanceEncyclopedia.dm should not be capitalized

Yup, it's not capitalized on my computer but git decided to be yucky

@ancient-engineer
Copy link
Contributor

MaintenanceEncyclopedia.dm should not be capitalized

Yup, it's not capitalized on my computer but git decided to be yucky

Classic git

Git decided to be yucky and ignore my earlier change.
@Uristthedorf
Copy link
Contributor Author

I wanted to give shadowpeople darkness reviving like nightmares do, but I was afraid it would be too op.

@@ -74,6 +74,14 @@
build_path = /obj/item/food/monkeycube
category = list(RND_CATEGORY_INITIAL, RND_CATEGORY_BIO_FOOD)

/datum/design/rat_cube // Monkestation, useful for chaplain and pathologist.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be in the modular directory

code/_globalvars/lists/maintenance_loot.dm Outdated Show resolved Hide resolved
code/modules/research/designs/biogenerator_designs.dm Outdated Show resolved Hide resolved
code/modules/research/designs/biogenerator_designs.dm Outdated Show resolved Hide resolved
name = "maintenance encyclopedia"
icon_state = "book1"
desc = "A burnt and damaged tome? Where did this come from?"
crafting_recipe_types = list(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think instead of just giving all of them it should pick 1 you dont already have to randomly give

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would the best way to do this? Are there any examples of this from other granters?

Copy link
Collaborator

@wraith-54321 wraith-54321 Aug 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something like uh
var/static/list/possible_recipes = [this list here]
and then on init do
crafting_recipe_types = list(pick(possible_recipes))
might also want to add a check for if they already know the recipe or not

monkestation/code/modules/religion/maint_god.dm Outdated Show resolved Hide resolved
invoke_msg = "I no longer want to see the light!"
favor_cost = 300

/datum/religion_rites/shadowascension/perform_rite(mob/living/user, atom/religious_tool)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add some spacing to all the things here to make them more readable

monkestation/code/modules/religion/maint_god.dm Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants