[PORT] Updates Node bootstrapping to v20 #2360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## About The Pull Request By default this will install node v20 LTS, but if a user is detected to be using win 7 it's node v14 This lets us run higher node versions (with presumably more stable and performant content) while allowing win 7 users to play I should note that this is making clean tgui builds run at ~6.7sec which is about a 6.9% speed increase (nice) from the previous #80310 ## Why It's Good For The Game Better tools ## Changelog N/A nothing player facing
"Compat" node version didn't work at all
## About The Pull Request Puts a switch inside our build tools that will download the appropriate node version based on your OS. #82334 ## Why It's Good For The Game Closes #83076 Allows players to play the game
This wasn't working for me because `OSMajor` was set to a string, not a number, so it failed the if check. Making this change made it work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Ports the following PRs:
Why It's Good For The Game
Node v20 LTS is newer, which will presumably bring speed and stability improvements with it. Additionally, this brings our build system more into parity with tgstation.
Changelog
No user-facing changes.
Any branches that include this change will automatically vendor and use the new version of Node. If the user has an old copy of Node v14, that copy will be untouched. If a user wishes to delete the old v14 version, they can find it at
tools/bootstrap/.cache/.Note that while I have tested to ensure this will successfully build, I have NOT tested if this will break anything, as the potential surface area seems much too large to test on my own.