Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a cloth stack recipe for satchels #2366

Merged
merged 2 commits into from
Jun 22, 2024

Conversation

RikuTheKiller
Copy link
Contributor

@RikuTheKiller RikuTheKiller commented Jun 22, 2024

About The Pull Request

Port of #77702
There is currently no way to get satchels in-game outside of roundstart spawns.
This fixes that, and brings it up to parity with the backpack and duffelbag recipes.

Why It's Good For The Game

Satchels are great when you can't free up your back slot.
Also the other two backpacks are already in, why not satchels?
Leather also has a leather satchel recipe already in the game.

Changelog

🆑
fix: Satchels can now be crafted out of cloth.
/:cl:

Copy link
Contributor

@ancient-engineer ancient-engineer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat, also could you move the comment after the slash but that's more a nitpick then anything

@RikuTheKiller
Copy link
Contributor Author

RikuTheKiller commented Jun 22, 2024

Can't do that I don't think. It didn't compile when I tried.
Anyway it's a port now, so the comment is gone.

@wraith-54321 wraith-54321 merged commit 3f723f9 into Monkestation:master Jun 22, 2024
19 checks passed
@LikeLakers2
Copy link
Contributor

I notified Riku of this in Discord (and they've made the appropriate changes), but tgstation appears to have made this same change in the past: tgstation/tgstation@0552b41

That said, that commit also makes a map change that we probably don't want, so we can consider this a manual port.

github-actions bot added a commit that referenced this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants