[PORT] Fix some bugs related to the xenomorph roundend report #2423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## About The Pull Request Fixes the 2% xeno's roundend report from turning the rest of the report into bold letters. ## Why It's Good For The Game look it's not all bold anymore  ## Changelog :cl: fix: Science Xenos no longer turn the entire roundend report into bold letters. /:cl:
## About The Pull Request `check_captivity` accepts a mob, not a mind  Which leads me to believe this always returned `null` and always failed. But checking further and this proc does not return a truthy or falsy value at all, meaning even if this runtime didn't happen, it still wouldn't function correctly. So I made it check for `CAPTIVE_XENO_PASS`. ## Changelog :cl: Melbert fix: Captive Xeno end round report should make a tad more sense /:cl:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Ports the following PRs:
Changelog
🆑
fix: (JohnFulpWillard) Science Xenos no longer turn the entire roundend report into bold letters.
fix: (Melbert) Captive Xeno end round report should make a tad more sense.
/:cl: