Ports several book-related PRs from /tg/ #2454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, unlike other paper items, you couldn't ignite books with a lighter or other hot item. Now, you can! (Also made it so the odd obscure mechanic of cutting pages out of books can be done by any sharp item, not just wirecutters or knives) Consistency. ~~Burning copies of WGW.~~ :cl: add: Books can now be burned just like any other paper item. add: You can cut pages out of books with any sharp item, not just knives or wirecutters. /:cl: --------- Co-authored-by: san7890 <[email protected]>
Books didn't render markdown and instead just dumped the raw contents, (after a html encode), into the window. Changes them to use tgui and support markdown rendering. Books should should look the same as the paper used to make them. :cl: fix: Book's no longer take your formatting and throw it out the window. refactor: Book display and rendering /:cl: --------- Co-authored-by: GoldenAlpharex <[email protected]> Co-authored-by: Mothblocks <[email protected]>
use that for book binding ## About The Pull Request Closes tgstation/tgstation#74996 ## Why It's Good For The Game ## Changelog :cl: fix: Bookbinder no longer takes your pen's font and throws it out the nearest window /:cl:
This started as a simple addition where burning a bible would curse you, but then I realized... Bibles aren't even proper books, thus can't be burned! So yeah, since that is not necessary due to how atom_storage works, I reworked that. Because burning bibles and getting cursed for it is funny.   :cl: add: You can burn bibles now! But heresy has a steep cost... /:cl: --------- Co-authored-by: san7890 <[email protected]>
This was referenced Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Ports the following PRs from /tg/:
Mostly want this as a precursor to porting more important refactors, tbh. The book formatting stuff is just a bonus.
Changelog
🆑
add: (ChungusGamer666) Books can now be burned just like any other paper item.
add: (ChungusGamer666) You can cut pages out of books with any sharp item, not just knives or wirecutters.
fix: (ZephyrTFA) Book's no longer take your formatting and throw it out the window.
refactor: (ZephyrTFA) Book display and rendering.
add: (ChungusGamer666) You can burn bibles now! But heresy has a steep cost...
/:cl: