[PORT] Deadchat Announcement Variety Packs 1 and 2 (+ tramming DLC!) #2457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## About The Pull Request Adds announce_to_ghosts()/notify_ghosts() calls to a bunch of different things. **THIS INCLUDES:** - Powersink being activated/reaching critical (explosion) heat capacity. - His Grace being awoken. - Hot Potatoes being armed. - Ascension Rituals being completed. - Eyesnatcher victims. - Ovens exploding as a result of the Aurora Caelus event. - Wizard Imposter spawns. - Rock-Paper-Scissors with death as the result of Helbital consumption. - BSA impact sites. - Spontaneous Appendicitis. - The purchasing of a badass syndie balloon. - The Supermatter beginning to delaminate. This was everything that I could think of that would be worth announcing to deadchat. These were all chosen with consideration to questions like "how easy would it be to spam deadchat with this?" and "will observers actually see the interesting thing happen, or just the aftermath?". Not gonna lie, I've really become an observer main as of recently. Maybe that's being reflected in my recent PRs. Who's to say? Deadchat Announcement Variety Pack 2 will probably never come out. Sorry. ## Why It's Good For The Game Gives deadchat a better indiciation of when/where something **REALLY FUNNY** is about to happen. Draws attention to certain things that are likely to gather an audience anyways, but sooner (for your viewing pleasure). In simple terms, it helps the observers observe things better. Some cases, such as the aurora caelus or helbitaljanken, are occurrences so rare that they deserve the audience. ## Changelog :cl: Rhials qol: Observers now recieve an alert when a powersink is activated/about to explode. qol: His Grace being awoken now alerts observers, to give you a headstart on your murderbone ghost ring. qol: Ascension Rituals being completed will also alert observers, for basically the same reason. qol: Arming a hot potato will now alert observers. Catch! qol: Eyesnatcher victims will now notify observers, and invite them to laugh at their state of misery and impotence. qol: Observers will be notified of any acute references to The Simpsons or other 20th Television America copyright properties. qol: Wizard Imposter spawns alert observers, much like any other ghost role event should. qol: Playing Rock-Paper-Scissors with death will now alert the observers and invite them to watch. Better not choke! qol: Observers now get an orbit link for BSA impact sites. Why does it keep teleporting me to the AI upload?? qol: Spontaneous Appendicitis now alerts deadchat. qol: The purchasing of a badass syndie balloon now alerts deadchat. You might not be any more powerful, but at least you have an audience. qol: When beginning to delaminate, the Supermatter will alert observers and invite them to watch the fireworks. /:cl:
…ups (#76053) ## About The Pull Request This adds ghost orbit popups for the following: - Macrobombs (or stacked microbombs) being triggered. - HFR Meltdowns. - Living players about to be gored by an emagged organ harvester. - Nuclear devices being armed. - Doomsday devices. - Blob hosts bursting. This also modifies the following ghost orbit popups: - Toy hot potatoes will no longer cause a popup when armed. - Normal spider eggs will not flash the byond window, only special egg types. ## Why It's Good For The Game Gives more gathering spots/information to deadchat. Let no entertaining moment in this game go unobserved. Spider eggs flashing your window for every single egg produced makes alt-tabbing suck. I saw some guy on the forums complaining about it and thought "huh yeah I guess he's got a point that pisses me off too" so here we are. ## Changelog :cl: Rhials qol: Basic spider eggs no longer flash the byond window when ready to hatch. qol: Toy hot potatoes no longer give a ghost notification. qol: Deadchat will be notified in the event of an imminent macrobomb detonation, HFR meltdown, organ harvesting, qol: Deadchat will be notified when a nuclear/doomsday device is activated, as well as when a blob-infection bursts. /:cl:
## About The Pull Request Another to add to tgstation/tgstation#75140 The bad luck omen has an event where you're electrocuted and guaranteed to be hit by the tram. This lets them get a few seconds notice.  ## Why It's Good For The Game Watch them go flying, hit a vending machine, and the vending machine falls on them gibbing their body. ## Changelog :cl: LT3 qol: Ghosts will now get a notification when someone is about to be hit by the tram /:cl:
…hosts calls (#79320) This helps clean up my favorite helper proc in the whole codebase, `notify_ghosts()`. The notify_suiciders, ignore_mapload, and flashwindow args are GONE. They have been replaced with the notify_flags bitflag argument. This was intended to make deadchat announcements a bitflag argument too, but those got reverted right before I originally wanted to submit this PR. The on-screen popup now shows the notification body when you hover it with your mouse again. The format is now `[notify_ghosts message] -- [click action (orbit/jump/play)]` Every single `notify_ghosts()` call has been changed to multiline format and has been given trailing commas. Pretty! Cleans up a proc that is very popular and going through a lot of changes at the time. Allows for further flexibility when this proc inevitably gets tweaked or improved. 12 -> 10 args is an improvement, and it doesn't impact the helper's flexibility at all. :cl: Rhials code: The notify_ghosts proc has been cleaned up. Please report any abnormal changes in deadchat notification behavior. qol: The on-screen deadchat popups now contain the notification blurb when hovered with your mouse again. /:cl:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Ports the following PRs from /tg/:
Changelog
🆑
qol: (Rhials) Observers now recieve an alert when a powersink is activated/about to explode.
qol: (Rhials) His Grace being awoken now alerts observers, to give you a headstart on your murderbone ghost ring.
qol: (Rhials) Ascension Rituals being completed will also alert observers, for basically the same reason.
qol: (Rhials) Arming a hot potato will now alert observers. Catch!
qol: (Rhials) Eyesnatcher victims will now notify observers, and invite them to laugh at their state of misery and impotence.
qol: (Rhials) Observers will be notified of any acute references to The Simpsons or other 20th Television America copyright properties.
qol: (Rhials) Wizard Imposter spawns alert observers, much like any other ghost role event should.
qol: (Rhials) Playing Rock-Paper-Scissors with death will now alert the observers and invite them to watch. Better not choke!
qol: (Rhials) Observers now get an orbit link for BSA impact sites. Why does it keep teleporting me to the AI upload??
qol: (Rhials) Spontaneous Appendicitis now alerts deadchat.
qol: (Rhials) The purchasing of a badass syndie balloon now alerts deadchat. You might not be any more powerful, but at least you have an audience.
qol: (Rhials) When beginning to delaminate, the Supermatter will alert observers and invite them to watch the fireworks.
qol: (Rhials) Basic spider eggs no longer flash the byond window when ready to hatch.
qol: (Rhials) Toy hot potatoes no longer give a ghost notification.
qol: (Rhials) Deadchat will be notified in the event of an imminent macrobomb detonation, HFR meltdown, organ harvesting,
qol: (Rhials) Deadchat will be notified when a nuclear/doomsday device is activated, as well as when a blob-infection bursts.
qol: (LT3) Ghosts will now get a notification when someone is about to be hit by the tram.
code: (Rhials) The notify_ghosts proc has been cleaned up. Please report any abnormal changes in deadchat notification behavior.
qol: (Rhials) The on-screen deadchat popups now contain the notification blurb when hovered with your mouse again.
/:cl: