Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PORT] Having a robot chest/legs no longer makes you drop all items upon losing your jumpsuit #2489

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

Absolucy
Copy link
Member

@Absolucy Absolucy commented Jul 1, 2024

About The Pull Request

Ports the following PRs from /tg/:

Changelog

🆑 Absolucy, Majkl-J
fix: Having an inorganic chest/legs no longer makes you drop your ID, belt or pocketed stuff upon losing your jumpsuit
code: The check that prevents your stuff from dropping when you have robotic parts is now more robust.
/:cl:

Majkl-J added 2 commits June 30, 2024 21:06
…ing your jumpsuit (#80673)

## About The Pull Request

See name, losing your jumpsuit with a robot chest/legs no longer spills
your stuff over the floor

## Why It's Good For The Game

Having a robot chest allows you to use the belt and ID inventory slots,
with legs adding pockets respectively, even when you don't have a
jumpsuit. Losing it probably shouldn't drop all your stuff when the
slots for it are still valid.

## Changelog

No idea if this is a qol, fix, add, or balance change. Feel free to edit
this to whichever one it's supposed to be
:cl:
fix: Having an inorganic chest/legs no longer makes you drop your ID,
belt or pocketed stuff upon losing your jumpsuit
/:cl:
## About The Pull Request

See #80673 
I took a nap and got an idea how to make it better, so here we are

Less snowflake code, very robust, very good

Technically runs way more checks so it is slower but eh I believe it's
worth it in this case

Fully tested, it works as it should

## Changelog
:cl:
code: The check that prevents your stuff from dropping when you have
robotic parts is now more robust
/:cl:
@wraith-54321 wraith-54321 merged commit 4a1304a into Monkestation:master Jul 23, 2024
22 checks passed
github-actions bot added a commit that referenced this pull request Jul 23, 2024
@Absolucy Absolucy deleted the dropfix branch July 24, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants