Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PORT] Mind link speech displays symbols correctly #2523

Merged
merged 2 commits into from
Jul 5, 2024

Conversation

Absolucy
Copy link
Member

@Absolucy Absolucy commented Jul 3, 2024

About The Pull Request

Ports tgstation/tgstation#76290, which removes a call to sanitize() in mind linker code because tgui_input_text() already sanitizes input by default, symbols now display correctly

Also ports tgstation/tgstation#84625

Why It's Good For The Game

It's a bugfix

Changelog

🆑 cnleth, Absolucy
fix: Symbols display correctly when sending messages via mind link
qol: Linked speech now prevents messages from highlighting if its a message you sent, or if you are the owner of said link..
qol: Linked speech messages are now marked as radio messages, for chat tab purposes.
/:cl:

rimefruit and others added 2 commits July 3, 2024 11:08
Closes #71991 
Removes a call to sanitize() in mind linker code because tgui_input_text() already sanitizes input by default, symbols now display correctly
## About The Pull Request

Linked speech now prevents messages from highlighting if its a message
you sent, or if you are the owner of said link.

Also, linked speech messages are now marked as radio messages, for chat
tab purposes.

## Why It's Good For The Game

Because when you have your own name highlighted, it's annoying having
every message with `[Shion Rosenthal's Slime Link]` highlighted, even if
it's _my own_ message.

## Changelog
:cl:
qol: Linked speech now prevents messages from highlighting if its a
message you sent, or if you are the owner of said link..
qol: Linked speech messages are now marked as radio messages, for chat
tab purposes.
/:cl:
@wraith-54321 wraith-54321 merged commit 87dc2be into Monkestation:master Jul 5, 2024
21 checks passed
github-actions bot added a commit that referenced this pull request Jul 5, 2024
@Absolucy Absolucy deleted the mindlink-fix branch July 6, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants