Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thanos #2869

Draft
wants to merge 49 commits into
base: master
Choose a base branch
from
Draft

Thanos #2869

wants to merge 49 commits into from
+5,300 −1,848

Conversation

ancient-engineer
Copy link
Contributor

About The Pull Request

Thanos

Why It's Good For The Game

Thanos

Changelog

🆑
add: Added the ability to buy the badmin gauntlet as wizard
/:cl:

Absolucy
Absolucy requested changes Aug 7, 2024
View reviewed changes
Copy link
Collaborator

@Absolucy Absolucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth noting that this is NOT comprehensive, and that this code predates things like ?. syntax, BYOND return types, many /tg/ refactors, span defines, etc.

monkestation/code/modules/mob/living/living_defines.dm Outdated Show resolved Hide resolved
monkestation/code/modules/mob/living/carbon/life.dm Outdated Show resolved Hide resolved
monkestation/code/modules/gauntlet/syndie.dm Outdated Show resolved Hide resolved
monkestation/code/modules/gauntlet/syndie.dm Outdated Show resolved Hide resolved
monkestation/code/modules/gauntlet/syndie.dm Outdated Show resolved Hide resolved
monkestation/code/modules/gauntlet/syndie.dm Outdated Show resolved Hide resolved
monkestation/code/modules/gauntlet/syndie.dm Outdated Show resolved Hide resolved
@Absolucy Absolucy added Stale and removed Stale labels Nov 8, 2024
@DexeeXI
Copy link
Collaborator

DexeeXI commented Dec 17, 2024 •
edited
Loading

Testing has failed, changes are still pending. Post regarding the contents of the PR is lacking as well. If there is any balance concerns, this also must needs be brought up with the admin team.

@DexeeXI DexeeXI added Major Feature A big new thing peak Balance perfectly balanced as all things should be labels Dec 17, 2024
@ancient-engineer
Copy link
Contributor Author

ancient-engineer commented Dec 17, 2024 •
edited
Loading

Testing has failed, changes are still pending. Post regarding the contents of the PR is lacking as well. If there is any balance concerns, this also must needs be brought up with the admin team.

Yeah when I get the energy I hope to fix it when I do I'll put something together to showcase what all this thanos shit does, also regarding balancing concerns I have no fucking clue if there are any I'm kinda stupid regarding anything involving game balance so if there any I didn't notice

@ancient-engineer
Copy link
Contributor Author

I'm going to convert this to a draft till I get the energy to work on it again

@ancient-engineer ancient-engineer marked this pull request as draft December 27, 2024 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kmla2 Kmla2 Kmla2 left review comments

@Absolucy Absolucy Absolucy requested changes

Assignees
No one assigned
Labels
Balance perfectly balanced as all things should be Feature A big new thing Major Merge Conflict peak
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ancient-engineer @DexeeXI @Absolucy @Kmla2