Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chasm.dm MMI Purgatory Patch #2947

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

TheWolfStudios
Copy link
Contributor

@TheWolfStudios TheWolfStudios commented Aug 14, 2024

Updates the Chasm.dm with a small code patch to delete the MMI when a borg falls in.

About The Pull Request

Small PR to fix up the issue of cyborgs falling into chasms being stuck in a purgatory with their MMI undestroyed at the bottom of the chasm until an ash storm comes by and finishes them off.

Why It's Good For The Game

helps make the death to the chasm be a far smoother experience for borgs and keeps them from, well, being stuck in a purgatory.

A fix for the issue occurred [ Here ]

Changelog

🆑
Fix: chasm.dm not properly Qdel-ing the cyborg's MMI when they fall in.
/:cl:

Updates the Chasm.dm with a small code patch to delete the MMI when a borg falls in.
@TheWolfStudios
Copy link
Contributor Author

Oh yeah, I forgot to leave a comment in the code about it, but the reason why it's under the message send instead of with the other Qdel calls for the actual body is just cause it was glitching out and not behaving right when it was... for reasons beyond me, tbh. lol
If this ends up causing a different problem with the chasms, then maybe we can try moving it to be before the Qdel but after all of the other stuff for the chasm fall.

code/datums/components/chasm.dm Outdated Show resolved Hide resolved
@Absolucy Absolucy merged commit cf52f58 into Monkestation:master Sep 11, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants