Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluffy Tongue mk III: Artificial Unintelligence #306

Closed
wants to merge 3 commits into from
Closed

Fluffy Tongue mk III: Artificial Unintelligence #306

wants to merge 3 commits into from

Conversation

SeeBeeSee
Copy link
Contributor

@SeeBeeSee SeeBeeSee commented Aug 28, 2023

About The Pull Request

Adds a fun new upgrade disk for the AI, so they can join in on the fun with their synced borgs! A great time for the whole station, especially Science.

Why It's Good For The Game

We're discussing this again? The first PR re-adding Fluffy Tongue and the brand-new module for borgs was, in a word, a resounding success. Borg suicide enjoyment rates rose substantially, and crew morale in shifts where Fluffy Tongue/UwU-speak upgrades were involved rose as well. Giving Science a means to share the fruits of their research with the AI is sure to be a hit.

Changelog

🆑
add: Added a fun upgrade disk that lots of AIs will learn to enjoy, eventually! :^)
/:cl:

@SeeBeeSee SeeBeeSee changed the title Adds AI UwU-speak disk to tech web/designs list Fluffy Tongue mk III: Artificial Unintelligence Aug 28, 2023
@Noot-Toot
Copy link
Contributor

To every other AI player, im sorry for telling seeb AI upgrades existed.

@SeeBeeSee
Copy link
Contributor Author

I didn't see the conflicts until now- I'll get that fixed once I get a free moment at work.


// Monkestation edit: AIs are not immune to the curse
/obj/item/ai_uwu_upgrade
name = "AI UwU-speak \"Upgrade\""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\improper

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain what you mean by this?

@@ -52,3 +52,26 @@
message_admins("[ADMIN_LOOKUPFLW(user)] has upgraded [ADMIN_LOOKUPFLW(AI)] with a [src].")
qdel(src)
return TRUE

// Monkestation edit: AIs are not immune to the curse
/obj/item/ai_uwu_upgrade
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be modularized.

icon = 'icons/obj/module.dmi'
icon_state = "datadisk5"

/obj/item/ai_uwu_upgrade/pre_attack(atom/A, mob/living/user, proximity)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no one letter vars

if(isAI(A))
AI.uwu_ify()
to_chat(AI, span_userdanger("[user] has upgraded you with... something?"))
to_chat(AI, "You feel a shudder in your microprocessors. Something isn't right...")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't have a span

Comment on lines +74 to +75
user.log_message("has upgraded [key_name(AI)] with a [src].", LOG_GAME)
message_admins("[ADMIN_LOOKUPFLW(user)] has upgraded [ADMIN_LOOKUPFLW(AI)] with a [src].")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"a [src]" -> "[src]"

Comment on lines +250 to +252
// it's a mercy to let the curse end in death, honestly
if (fluffy_tongue)
UnregisterSignal(src, COMSIG_MOB_SAY)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need to do this

Comment on lines +1154 to +1169
/mob/living/silicon/ai/proc/uwu_ify()
RegisterSignal(src, COMSIG_MOB_SAY, PROC_REF(handle_speech))

/mob/living/silicon/ai/proc/handle_speech(datum/source, list/speech_args)
SIGNAL_HANDLER
var/message = speech_args[SPEECH_MESSAGE]

if(message[1] != "*")
message = replacetext(message, "ne", "nye")
message = replacetext(message, "nu", "nyu")
message = replacetext(message, "na", "nya")
message = replacetext(message, "no", "nyo")
message = replacetext(message, "ove", "uv")
message = replacetext(message, "r", "w")
message = replacetext(message, "l", "w")
speech_args[SPEECH_MESSAGE] = message
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modularize, add code docs

Comment on lines 1120 to +1121
"borg_upgrade_cringe",
"ai_upgrade_cringe",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modular comment

@@ -45,3 +45,17 @@
RND_CATEGORY_EQUIPMENT + RND_SUBCATEGORY_EQUIPMENT_SCIENCE
)
departmental_flags = DEPARTMENT_BITFLAG_SCIENCE

// Monkestation change: UwU-speak module for AIs too because I hate them more than borg players
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't need this

id = "ai_upgrade_cringe"
build_type = PROTOLATHE | AWAY_LATHE
// same price as the borg upgrade, plus some iron
materials = list(/datum/material/iron = 1000, /datum/material/gold = 2000, /datum/material/diamond = 1000, /datum/material/bluespace = 500)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

debatably should use bananium

@SeeBeeSee SeeBeeSee marked this pull request as draft September 7, 2023 02:25
@SeeBeeSee
Copy link
Contributor Author

Finding myself with less free time than I'd like to get to this- I'll mark it as a draft and re-open when I can get to it and the requested changes are complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants