-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fluffy Tongue mk III: Artificial Unintelligence #306
Conversation
To every other AI player, im sorry for telling seeb AI upgrades existed. |
I didn't see the conflicts until now- I'll get that fixed once I get a free moment at work. |
|
||
// Monkestation edit: AIs are not immune to the curse | ||
/obj/item/ai_uwu_upgrade | ||
name = "AI UwU-speak \"Upgrade\"" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
\improper
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain what you mean by this?
@@ -52,3 +52,26 @@ | |||
message_admins("[ADMIN_LOOKUPFLW(user)] has upgraded [ADMIN_LOOKUPFLW(AI)] with a [src].") | |||
qdel(src) | |||
return TRUE | |||
|
|||
// Monkestation edit: AIs are not immune to the curse | |||
/obj/item/ai_uwu_upgrade |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can be modularized.
icon = 'icons/obj/module.dmi' | ||
icon_state = "datadisk5" | ||
|
||
/obj/item/ai_uwu_upgrade/pre_attack(atom/A, mob/living/user, proximity) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no one letter vars
if(isAI(A)) | ||
AI.uwu_ify() | ||
to_chat(AI, span_userdanger("[user] has upgraded you with... something?")) | ||
to_chat(AI, "You feel a shudder in your microprocessors. Something isn't right...") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this doesn't have a span
user.log_message("has upgraded [key_name(AI)] with a [src].", LOG_GAME) | ||
message_admins("[ADMIN_LOOKUPFLW(user)] has upgraded [ADMIN_LOOKUPFLW(AI)] with a [src].") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"a [src]" -> "[src]"
// it's a mercy to let the curse end in death, honestly | ||
if (fluffy_tongue) | ||
UnregisterSignal(src, COMSIG_MOB_SAY) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you don't need to do this
/mob/living/silicon/ai/proc/uwu_ify() | ||
RegisterSignal(src, COMSIG_MOB_SAY, PROC_REF(handle_speech)) | ||
|
||
/mob/living/silicon/ai/proc/handle_speech(datum/source, list/speech_args) | ||
SIGNAL_HANDLER | ||
var/message = speech_args[SPEECH_MESSAGE] | ||
|
||
if(message[1] != "*") | ||
message = replacetext(message, "ne", "nye") | ||
message = replacetext(message, "nu", "nyu") | ||
message = replacetext(message, "na", "nya") | ||
message = replacetext(message, "no", "nyo") | ||
message = replacetext(message, "ove", "uv") | ||
message = replacetext(message, "r", "w") | ||
message = replacetext(message, "l", "w") | ||
speech_args[SPEECH_MESSAGE] = message |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
modularize, add code docs
"borg_upgrade_cringe", | ||
"ai_upgrade_cringe", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
modular comment
@@ -45,3 +45,17 @@ | |||
RND_CATEGORY_EQUIPMENT + RND_SUBCATEGORY_EQUIPMENT_SCIENCE | |||
) | |||
departmental_flags = DEPARTMENT_BITFLAG_SCIENCE | |||
|
|||
// Monkestation change: UwU-speak module for AIs too because I hate them more than borg players |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't need this
id = "ai_upgrade_cringe" | ||
build_type = PROTOLATHE | AWAY_LATHE | ||
// same price as the borg upgrade, plus some iron | ||
materials = list(/datum/material/iron = 1000, /datum/material/gold = 2000, /datum/material/diamond = 1000, /datum/material/bluespace = 500) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
debatably should use bananium
Finding myself with less free time than I'd like to get to this- I'll mark it as a draft and re-open when I can get to it and the requested changes are complete. |
About The Pull Request
Adds a fun new upgrade disk for the AI, so they can join in on the fun with their synced borgs! A great time for the whole station, especially Science.
Why It's Good For The Game
We're discussing this again? The first PR re-adding Fluffy Tongue and the brand-new module for borgs was, in a word, a resounding success. Borg
suicideenjoyment rates rose substantially, and crew morale in shifts where Fluffy Tongue/UwU-speak upgrades were involved rose as well. Giving Science a means to share the fruits of their research with the AI is sure to be a hit.Changelog
🆑
add: Added a fun upgrade disk that lots of AIs will learn to enjoy, eventually! :^)
/:cl: