Adds pathology goggles and gives pathologists access to pharmacy #3233
+344
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good feature. Hated how I couldn't make chems round start for pathology without getting let into pharma first. Also the science goggles let even chemists see pathogens which seemed kinda weird so glad that got split up. Now we just need pathogens to actually increase faster in strength when applying virus plasma because that is ultra slow. |
|
@RikuTheKiller mergeconflicxts |
Yay ill fix them later today |
I have redefined today as tomorrow lmao |
|
okay something fucked up in the merge process |
RikuTheKiller
force-pushed
the
patho_fixes
branch
from
9a0f1ac to
fc2eefd
Compare
RikuTheKiller
force-pushed
the
patho_fixes
branch
from
a2d1866 to
92e08b2
Compare
|
will tm if conflicts are fixed |
|
merge conflicts + inactivity |
Kitsunemitsu
added
Tweak
|
Conflicted, Stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Adds viral analyzer goggles, i.e. pathology goggles.
It's a replacement for the plain old science goggles they had previously.
Pathologist now spawns with them by default and maps have been adjusted. (did it through code, tell me if it's an issue)
Additionally, the new goggles have an item action to toggle the viral analyzer aspect on and off.
The pathology goggles have the reagent scanning of science goggles, but not the item/machine scanning.
Their addition also includes a refactor for the virusView() proc into a trait + element combo.
Also gives pathologists access to pharmacy regardless of skeleton crew status.
Why It's Good For The Game
Non-pathologists shouldn't have the ability to scan for pathogens roundstart.
Science goggles already had 2 features even before viral scanning was added to it, so it needed to get split.
The toggle action helps with the absolute visual overload when you have airborne diseases and such.
Pathologist now relies on extremely niche chems that no chemist (rightfully) knows how to make.
There's also an existing precedent for exceptions like this, since MD can access pharmacy as well.
Changelog
🆑
add: New pathology goggles with a nifty toggle for the pathogen visuals. No more visual overload!
balance: Pathologists now have access to pharmacy, in light of their new dependence on obscure chems.
balance: Science goggles can't see pathogens anymore. You're more reliant on the pathologist again.
fix: Virus view now works at roundstart. I fixed it by just refactoring it into something sensible.
/:cl: