Fix cleaning stickers off the floor runtiming #3423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 16, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
so it turns out turf.drop_location() tries to return the turf's area - when it should be returning the turf itself, as that's the usual result of drop_location() anyways
this resulted in a runtime when cleaning stickers on the floor - as area.drop_location() runtimes, returning null, and it'd try to forceMove the sticker to nullspace as a result.
Changelog
🆑
fix: Cleaning stickers off the floor now properly drops the sticker instead of runtiming and permanently sending it to nullspace.
/:cl: