Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] 13 year old singularity bug fixed #3432

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

RandomDudeFromTheRim
Copy link
Contributor

@RandomDudeFromTheRim RandomDudeFromTheRim commented Sep 16, 2024

About The Pull Request

This is a port of tgstation/tgstation#83005
Stage 2 singularities have the wrong step size, allowing them to eat the containment field if they happen to be right next to it.
(For instance, if they are contained in a 3x3 or 4x4 field)
2 lines of code, and that's fixed.

Why It's Good For The Game

BEFORE

327262888-821f43f6-85ca-482b-a905-614f2b1c8359.mp4

AFTER

327269777-4580d23a-41f0-4485-8454-4e991aa38344.mp4

Changelog

🆑
fix: Stage 2 singularities should no longer escape containment
/:cl:

@ThePooba ThePooba merged commit d940149 into Monkestation:master Sep 16, 2024
25 checks passed
github-actions bot added a commit that referenced this pull request Sep 16, 2024
@RandomDudeFromTheRim RandomDudeFromTheRim deleted the 13yearoldfix branch December 31, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants