-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI improvements #3505
Merged
Merged
CI improvements #3505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Absolucy
force-pushed
the
ci-improvements
branch
from
September 24, 2024 01:28
5bc4620
to
eccf6a2
Compare
Makes sure we're on the latest versions of the stuff we never check (i.e. actions/checkout).
- Change committer to tgstation-server-ci[bot] Also denaturing DMAPI slightly so I can test.
Start gate means we only need to check `[ci skip]` once Completion gate means we need only one status check in our rulesets.
TGS now does some validation of the access token you give it, which doesn't work well in an actions environment. Just don't give it a token unless absolutely necessary. Private repos can eat shit cause this is AGPL code.
## About The Pull Request I want this lint to go away. it's killing me internally. ## Why It's Good For The Game It's a pragma that no longer exists
Closes #86567 Don't think any of these were found/reported or actually could trigger in-game Glory to OpenDream :cl: code: Fixed multiple minor logic issues with code found by OpenDream's new pragma /:cl:
Absolucy
force-pushed
the
ci-improvements
branch
from
September 24, 2024 03:33
eccf6a2
to
73a1ab3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Ports the following PRs from /tg/:
Also, disables NorthStar, as we don't use it anyways, so it's a waste of a CI runner to test against it.
Changelog
No user-facing changes