Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI improvements #3505

Merged
merged 11 commits into from
Sep 24, 2024
Merged

CI improvements #3505

merged 11 commits into from
Sep 24, 2024

Conversation

@Absolucy Absolucy marked this pull request as draft September 22, 2024 05:37
@Absolucy Absolucy marked this pull request as ready for review September 24, 2024 01:28
Cyberboss and others added 10 commits September 23, 2024 23:33
Makes sure we're on the latest versions of the stuff we never check
(i.e. actions/checkout).
- Change committer to tgstation-server-ci[bot]

Also denaturing DMAPI slightly so I can test.
Start gate means we only need to check `[ci skip]` once

Completion gate means we need only one status check in our rulesets.
TGS now does some validation of the access token you give it, which
doesn't work well in an actions environment. Just don't give it a token
unless absolutely necessary.

Private repos can eat shit cause this is AGPL code.
## About The Pull Request

I want this lint to go away. it's killing me internally.
## Why It's Good For The Game

It's a pragma that no longer exists
Closes #86567
Don't think any of these were found/reported or actually could trigger
in-game

Glory to OpenDream

:cl:
code: Fixed multiple minor logic issues with code found by OpenDream's
new pragma
/:cl:
@Absolucy Absolucy merged commit 9664346 into Monkestation:master Sep 24, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants