Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safety First & Cybersun Juggernaut Suit Balance Change #3535

Merged
merged 7 commits into from
Oct 4, 2024

Conversation

SirNightKnight
Copy link
Collaborator

@SirNightKnight SirNightKnight commented Sep 24, 2024

About The Pull Request

Misc.
-Helmets no longer burn as I have added the flag for it to the helmet parent.
-Hazard vests can hold oxygen tanks, adds more utility to them for engineers..
-Can't be shoved down in a Cybersun Juggernaut Hardsuit.

Emergency Space Suits.
-Packaged in bulky metal boxes that contain a helmet, suit, and an emergency oxygen tank that may or may not have oxygen.
-Can be torn by attacks breaking the pressure seal (10% for both the helmet and suit, it's so crap the region doesn't matter). In the case of the helmet the visor snaps so a certain xeno race has an easier time with their young ones (might have to sprite a variant for this but digi code scares me). Oh and whenever the suit or helmet is torn it plays some sound effects.
-Has the crappiest cell I could find for the thermal regulator, second only to the emergency light cell in the code. Runs for a whopping minute if kept on continuously.

Oxygen Candles.
-Pretty nifty flare type things that release warm oxygen, we ported them from... somewhere? But they aren't implemented currently. So I implemented them! One can be found in every emergency toolbox.
-Note: In testing they can barely pressurize a single tile with oxygen. Buffed them to be more useful.

New Cargo Crates.
-Liquid pump crate for service, because floods are the worst thing to deal with. Because being a janitor who has to mop up a station wide piss flood because one assistant had too much time on their hands makes my soul wither away. Also you can't get them currently besides them being mapped in roundstart as far as I know. Same price as a portable scrubber crate.
-Emergency EVA Crate. Contains three emergency toolboxes, three boxed emergency suits, and one box of oxygen candles. 800 credit cost.

Emergency Closet Changes.
-Each emergency closet now contains a boxed emergency space suit, emergency toolbox, two breath masks, emergency oxygen tank, and oxygen tank guaranteed.
-Now a 50% for each type of the old contents (nothing is still 4%).
Content types include:
two breath masks and emergency oxygen tanks
emergency tank, breath mask, and emergency first aid kit
oxygen tank and breath mask
AND NOW INCLUDES
oxygen tank, emergency oxygen tank, and two breath masks instead of just an emergency oxygen tank and breath mask :)

Why It's Good For The Game

WOO MORE TEXT!
Cybersun Juggernaut Suit.
-YOU CAN'T SHOVE DOWN THE WALL!

Helmets being Fire Proof.
Pretty sure them being flammable in the first place is a bug. Armor doesn't burn so why should helmets?
Note fire proof doesn't mean fire proof, just means it won't burn and fall apart. Your noggin will still get cooked.

Oxygen Candles.
They are cool and can be used in emergencies to stave off death from spacing if you get in a secluded, small enough area and use one.

Emergency Space Suits.
Help our pop is 80 average now and EVA storage still has the same number of suits. I made them crappy enough that they are only really useful for a one way trip through a spaced portion of the station. Did I mention they slow you down heavily?
May or may not be related to my totally-not-goon nukie project where one of the classes uses a modified emergency space suit to infiltrate the station*

Emergency Closet Changes.
Makes their contents overall more consistent which is good in emergencies.

Liquid Pump Crate.
Currently there is no way of obtaining liquid pumps besides them being mapped in roundstart, and some maps don't even have them mapped in which is absolute suffering when floods show up :)

Changelog

🆑
add: Added emergency EVA suits to emergency closets.
add: Implemented oxygen candles, they can be found in emergency toolboxes.
add: Added the Emergency EVA crate and Liquid Pump crate to Cargo
qol: Made emergency closet contents more consistent.
qol: Oxygen candles are more potent.
qol: Hazard vests can hold large oxygen tanks.
balance: Cybersun Juggernaut Suit now has shove protection akin to riot armour.
fix: Helmets no longer have the flammable quality.

/:cl:

@KnigTheThrasher
Copy link
Contributor

candles were from nova/skyrat, they were supposed to spawn in emergency boxes you start with

@SirNightKnight
Copy link
Collaborator Author

candles were from nova/skyrat, they were supposed to spawn in emergency boxes you start with

i like crew suffering so i think they are fine where they are in emergency toolboxes. survival boxes having them would make them way too abundant.

@KnigTheThrasher
Copy link
Contributor

candles were from nova/skyrat, they were supposed to spawn in emergency boxes you start with

i like crew suffering so i think they are fine where they are in emergency toolboxes. survival boxes having them would make them way too abundant.

you said they hardly even fill a single tile with oxygen tho, at least make them better so they are useful if you don't want them everywhere

@SirNightKnight
Copy link
Collaborator Author

candles were from nova/skyrat, they were supposed to spawn in emergency boxes you start with

i like crew suffering so i think they are fine where they are in emergency toolboxes. survival boxes having them would make them way too abundant.

you said they hardly even fill a single tile with oxygen tho, at least make them better so they are useful if you don't want them everywhere

was gonna wait until it's test merged to start messing with the oxygen candle but i can start doing that now

@LassiH
Copy link

LassiH commented Sep 26, 2024

if firefighting helmets dont block pressure damage wont that cause you to die in any fire from overpressure

@destrucktoid
Copy link

Why is balance changes to the juggernaut suit bundled in with these changes? shouldn't they be in a separate PR? They seem to be randomly bundled in with these other fixes and additions for no reason and it's seemingly out of the scope of this PR.

Also you didn't do a changelog.

@Shoddd
Copy link
Collaborator

Shoddd commented Sep 26, 2024

When you extinguish a fire, the pressure and temp on that tile drops to space level, fire helmets not blocking pressure means putting out a fire will cause you to start dying from pressure.

@SirNightKnight SirNightKnight changed the title Safety First+ Safety First & Cybersun Juggernaut Suit Balance Change Sep 27, 2024
@SirNightKnight
Copy link
Collaborator Author

Why is balance changes to the juggernaut suit bundled in with these changes? shouldn't they be in a separate PR? They seem to be randomly bundled in with these other fixes and additions for no reason and it's seemingly out of the scope of this PR.

Also you didn't do a changelog.

title changed and i'll write the changelog now. was waiting for a code review/feedback

@SirNightKnight
Copy link
Collaborator Author

if firefighting helmets dont block pressure damage wont that cause you to die in any fire from overpressure

rarely a problem i have seen when people fight fires but i'll revert the change nonetheless

@wraith-54321
Copy link
Collaborator

wraith-54321 commented Sep 29, 2024

The emergency space suit box oxy tanks should just always have oxygen, it being random sounds very un-fun
also bad for new players who wont know thats possible, if they must be able to not have oxy then just make them not always have the tank in them

@SirNightKnight
Copy link
Collaborator Author

The emergency space suit box oxy tanks should just always have oxygen, it being random sounds very un-fun also bad for new players who wont know thats possible, if they must be able to not have oxy then just make them not always have the tank in them

okay i'll make it less evil, did it for flavour initially

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants