[PORT] Fixes the biogenerator displaying item costs that were being divided by the machine's efficiency twice #3619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…by the machine's efficiency twice (#74939) It was really bugging me that I would see a price being displayed in my biogenerator, only for it to then cost me far more than what was displayed. Looking into it, I realized that it was simply an issue with it dividing the cost by the efficiency in the TGUI, when that math was already done DM-side. Being charged the cost you see on the machine is good. :cl: GoldenAlpharex fix: Biogenerators now display the accurate price of their products after having been upgraded, as they no longer visually apply the efficiency discount twice. /:cl:
This was referenced Oct 1, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of tgstation/tgstation#74939
Changelog
🆑 GoldenAlpharex
fix: Biogenerators now display the accurate price of their products after having been upgraded, as they no longer visually apply the efficiency discount twice.
/:cl: