Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes void cloak space proof (Kinda) #3639

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Conversation

Gw0sty
Copy link
Collaborator

@Gw0sty Gw0sty commented Oct 1, 2024

About The Pull Request

Gives Heretic void cloak the ability to prevent pressure damage when hooded. (Aka invisible.)

Why It's Good For The Game

I took inspiration for this change from tgstation/tgstation#85728. Where they phrase it well.
"Reasoning: Not having pressure resistance as a Void Heretic just sucks, as you are clearly intended to somewhat go into space at some point; giving it to the cloak is a good compromise since you sacrifice better protection (the armor values of the cloak are pitiful) for utility."

Unlike TG's version, this one has to have the hood up to grant the pressure immunity. Meaning they'll have to sacrifice the innate focus when unhooded for space protection. Also, by proxy preventing any heathens from getting the pressure immunity benefits as they cannot access the hood aspect needed for full pressure immunity.

Finally it gives all heretics the ability to reasonably use space phase without killing themself. As it granted mobility but not space immunity. Now if you also have a void cloak and Aristocrat's Way, (Which you'll likely have due to how the side trees work.) you can use the space phase without the consequences.

Changelog

🆑
add: Made it so the void cloak stops pressure damage when hooded.
/:cl:

@Whiskey4
Copy link

Whiskey4 commented Oct 4, 2024

I really need to farm up more to get the full PR codebountied. But yeah nobody uses void cloak so this is a nice addition to underused side paths.

@Absolucy Absolucy merged commit 97576fc into Monkestation:master Oct 10, 2024
23 checks passed
github-actions bot added a commit that referenced this pull request Oct 10, 2024
@Gw0sty Gw0sty deleted the void_heretic branch November 26, 2024 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants