Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Nuclear operatives can now be other species. Pref toggle to always be human as operative #376

Merged
merged 7 commits into from
Oct 20, 2023

Conversation

Gboster-0
Copy link
Contributor

Original PR: tgstation/tgstation#77970

About The Pull Request

image

When #16075 was created in the ancient year of 2016, it was a stopgap solution to plasmamen spawning in with a regular nukie outfits and burning to death. As a result, nukies have been human-only for the past seven years. I come to you today to remove the stopgap, and once again enable non-human nukies.

This was approved in the past (#59590), and I'm assuming that approval is still valid. Let's take a look at how things work:

Spawning in as a Nuclear Operative (leader included), Lone Operative, Clown Operative, or Reinforcement will now set your species to the one if your prefs. That means lizard, cat, plasma, and ethereal nukies are all on the table now.

Plasmamen now have their own syndicate envirohelm/suit combo. It doesn't look fantastic (it's just a palette swapped roboticists envirosuit) but I think it's serviceable at least. When the operative antag datum is given, and the owner is a plasmamen, they will instead be given an alternate outfit with these equipped. Loneop plasmamen will instead be given a MODsuit with the plasma stabilizer MODule installed. These MODules also spawn in the firebase lockers in case they're needed.

But what about the AI? Fortunately for the balancebrains in the crowd, there is a preference (enabled by default!) to always roll human as an operative. The AI still has to reasonably assume that nukies are human until proven otherwise so please don't think this will affect the rules of engagement for anyone not directly opting into it.

image

(This pref will only appear if you have a nukie job enabled in the antag menu!)

Huge thanks to Melbert who let me peek at his code on a branch trying to do the same thing. My approach ended up being entirely on the antag datum, with nothing on the job datum.

Why It's Good For The Game

Rectifies a curious change made long long ago. Expands customization to nukies while not affecting balance for those who care.

Changelog

🆑 Rhials
add: Nuclear operatives have expanded the scope of their hiring practices. Members of all species can now roll nukie!
qol: The preferences menu now has an option to always be human when being selected for a nuclear operative role. Check it out!
image: Plasmaman operative envirosuits.
/🆑

@dwasint dwasint merged commit 642488c into Monkestation:master Oct 20, 2023
19 checks passed
@Gboster-0 Gboster-0 deleted the le-nukies-mirror branch October 20, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants