Minor QoL and bug fixes for mining #3847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Absolucy
requested changes
Oct 21, 2024
Absolucy
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Makes holoparasites/powerminers ash storm proof
Makes iceboots burn proof
Ports tgstation/tgstation#81274 to fix #3831 and fix #2990
Why It's Good For The Game
Holoparasites in general, and espically powerminers aren't currently ash storm proof meaning even if owner is they still take damage from their holopara just existing, and double damage if not.
Iceboots are a miner item and also very important to icebox mining, yet they aren't burn proof as they should be
Port fixes making a mining mob sentient pacifying all of lavaland letting you walk up to megafaunas and kill them without them fighting back. By sentient potion not giving you that faction, this blanket fixes some other stuff that could be cheesed with gaining factions
Changelog
🆑
fix: Making a mob sentient no longer gives you all of their factions.
qol: Miner Iceboots are now fireproof
qol: Holoparasites, guardian spirits, and power miners are now ash storm proof.
/:cl: