Refactor patreon+twitch data to be linked to /datum/player_details than /client
#4408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Absolucy
force-pushed
the
player-details-refactor
branch
from
6a51b45 to
3f59a52
Compare
…rather than `/client`
Absolucy
force-pushed
the
player-details-refactor
branch
from
3f59a52 to
3b7496c
Compare
Absolucy
added a commit
to Absolucy/Monkestation
that referenced
this pull request
Dec 17, 2024
…etails` than `/client` (Monkestation#4408)" This reverts commit d61b73e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
see title
this shouldn't have any player-facing changes, this is simple refactoring the code to be cleaner and more resilient.
Why It's Good For The Game
Avoids some runtimes if player disconnects early, and avoids some repeated operations (mostly SQL queries) during reconnects.
Changelog
🆑
refactor: Refactored how some internal stuff regarding Patreon and Twitch ranks are handled.
/:cl: