Stowaways are properly removed from manifest #4422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Absolucy
requested changes
Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Makes stowaways properly removed from manifest
Removes code that tries to open a slot in stowaways job
Why It's Good For The Game
Fixes bug
While it didn't work, stowaways shouldn't auto open a slot in the job they join, removing this was ok'd by abraxis. Them automatically opening a slot while making sense isn't great from a gameplay side of things making two of jobs that possibly shouldn't and such.
Changelog
🆑
del: deleted stowaway code that tried to open a new job slot
fix: stowaways are properly removed from the manifest
/:cl: