3+ ascended heretics = lambda alert (+ fix nar'sie/ratvar alert levels) #4442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (#88149) I kinda did a small refactor of heretic ascension announcement code, based on what I did in BeeStation/BeeStation-Hornet#11925 instead of each heretic ascension individually doing `priority_announce` in `on_finished_recipe`, there's just `announcement_text` and `announcement_sound` vars now, and a `announce_ascension` proc is called in the shared `on_finished_recipe` of all final rituals. The only reason the `announce_ascension` proc is needed is because lock path uses a different format from all the other announcements, so the final lock ritual needs to override the announcement so it can stay the same. Also made all heretic ascensions which apply traits use the type as the trait source - before, they were inconsistently either using the type, name, `REF(src)`, or `MAGIC_TRAIT` as the trait source. also ash ascension did not need a `if(length(traits_to_apply))` check before adding traits, bc it's adding traits from a *static, populated list*. ascension doesn't feel like a real word anymore with how much I've typed and read it in the past 20 mins or so lol cleaner code = good :cl: refactor: Cleaned up code relating to heretic ascension announcements and traits. /:cl:
…he alert level to Lambda
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
according to Huk on discord:
so, if a heretic ascends, while 2 other ascended heretics are alive, this will automatically raise the alert to Lambda (5 secs after the announcement)
I also ported the refactor portion of my upstream PR, tgstation/tgstation#88149, and made it so nar'sie and ratvar properly set the alert to lambda instead of delta (also, clock cult code actually uses the security level defines now instead of just plain numbers)
also made it so ascended heretics are in the ghost orbit menu
Changelog
🆑
add: 3+ living ascended heretics will automatically raise the alert level to Lambda.
fix: Nar'sie and Ratvar now properly raise the alert level to Lambda.
qol: Ascended heretics are now in their own category in the ghost orbit menu.
refactor: Cleaned up code relating to heretic ascension announcements and traits.
/:cl: