Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PORT] Transforms the chat feedback of cutting down logs and pulling cotton into balloon alerts, and simplifies their merging code #4457

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

Absolucy
Copy link
Collaborator

@Absolucy Absolucy commented Dec 2, 2024

About The Pull Request

Ports tgstation/tgstation#83494

Anyone that's ever played botany knows that cutting down tower cap logs simply nukes your chat, it used to spam it with three messages for each log that's been turned into planks.

Not anymore!

Now, it simply shows you a balloon alert to inform you of how many planks you've created. Not only that, but it also cleans up the code that was being used there, instead letting the stacks attempt to merge on their own, rather than having their own implementation, which is what led to cotton bundles to cause runtimes from trying to merge things manually after accidentally having the spawned raw cotton being merged automatically.

It also has the benefit of no longer causing the final stack of items to move all over the place every time you cut a log, instead it stays in place until it's full, and only then does a new one appear at a random position on the tile, making it a lot less annoying when cutting logs whilst standing on the same tile as them.

Why It's Good For The Game

Less chat spam is always good. You don't need a live update to the count of planks in your plank stack, you can just shift-click it to examine it to know. Much, much neater that way.

Changelog

🆑 Absolucy, GoldenAlpharex
qol: Grown logs no longer spam your chat when cut into planks, instead displaying balloon alerts informing you of how many planks were made!
qol: Cotton and Durathread bundles no longer spam your chat either, and display a balloon alert instead.
fix: Cotton and Durathread bundles no longer runtime when creating raw cotton/durathread from the created stack having been merged with an existing one.
/:cl:

GoldenAlpharex and others added 2 commits December 2, 2024 02:40
…into balloon alerts, and simplifies their merging code (#83494)

## About The Pull Request
Anyone that's ever played botany knows that cutting down tower cap logs
simply nukes your chat, it used to spam it with ***three*** messages for
each log that's been turned into planks.

*Not anymore!*

Now, it simply shows you a balloon alert to inform you of how many
planks you've created. Not only that, but it also cleans up the code
that was being used there, instead letting the stacks attempt to merge
on their own, rather than having their own implementation, which is what
led to cotton bundles to cause runtimes from trying to merge things
manually after accidentally having the spawned raw cotton being merged
automatically.

It also has the benefit of no longer causing the final stack of items to
move all over the place every time you cut a log, instead it stays in
place until it's full, and *only then* does a new one appear at a random
position on the tile, making it a lot less annoying when cutting logs
whilst standing on the same tile as them.

## Why It's Good For The Game
Less chat spam is *always* good. You don't *need* a live update to the
count of planks in your plank stack, you can just shift-click it to
examine it to know. Much, much neater that way.

## Changelog

:cl: GoldenAlpharex
qol: Grown logs no longer spam your chat when cut into planks, instead
displaying balloon alerts informing you of how many planks were made!
qol: Cotton and Durathread bundles no longer spam your chat either, and
display a balloon alert instead.
fix: Cotton and Durathread bundles no longer runtime when creating raw
cotton/durathread from the created stack having been merged with an
existing one.
/:cl:
@Absolucy Absolucy changed the title [PORT] Transforms the chat feedback of cutting down logs and pulling cotton into balloon alerts, and simplifies their merging code (#83494) [PORT] Transforms the chat feedback of cutting down logs and pulling cotton into balloon alerts, and simplifies their merging code Dec 2, 2024
@Absolucy Absolucy merged commit b3d91a1 into Monkestation:master Dec 2, 2024
27 checks passed
@Absolucy Absolucy deleted the cotton-fix branch December 2, 2024 16:14
github-actions bot added a commit that referenced this pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants