Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix chemmaster #4523

Merged
merged 4 commits into from
Dec 9, 2024
Merged

Conversation

wraith-54321
Copy link
Collaborator

@wraith-54321 wraith-54321 commented Dec 9, 2024

About The Pull Request

ports tgstation/tgstation#88002 and tgstation/tgstation#87780

Why It's Good For The Game

Changelog

🆑 SyncIt21
/:cl:

wraith-54321 and others added 4 commits December 9, 2024 11:42
- Fixes #88001. Pllumbing pill press now reads the maximum volume of the
selected product instead of showing a constant of 50u. Patches have a
maximum volume of 40u so we send that to the UI
- Plumbing pill press now validates the selected container to see if
it's a valid printable option to prevent href exploits. It has the same
issue as #87779 but now that's fixed
- Plumbing pill press checks to see if the input volume is a number and
returns false to stop the UI from updating if not

:cl:
fix: plumbing pill press advertises the correct maximum volume of your
selected product instead of always 50u on the UI
code: plumbing pill press validates selected container to prevent href
exploits
code: plumbing pill press validates input volume to see if it's a number
/:cl:
@wraith-54321 wraith-54321 merged commit 02a4891 into Monkestation:master Dec 9, 2024
21 of 22 checks passed
@wraith-54321 wraith-54321 deleted the hotfix-chemmaster branch December 10, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants