Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes our bitrunning up-to-date with TG, also alt job titles for bitrunners from skyrat and the clown bitrunning ruin changes #455

Merged
merged 9 commits into from
Oct 16, 2023

Conversation

Gboster-0
Copy link
Contributor

Original PR's:

tgstation/tgstation#78659 - Bitrunning "Clown Planet" Mission Fix
tgstation/tgstation#78845 - Fix bitrunning drinking glass using the wrong subtype
tgstation/tgstation#78818 - Bitrunning hotfix 3
tgstation/tgstation#78892 - Abandoned Domains: Adds two new psyker-oriented virtual domains

Skyrat-SS13/Skyrat-tg#24083 - [MODULAR] [QOL] Bitrunner Alt-titles + Others + QoL

About The Pull Request

Ports all of the upstream bitrunner thingies from TG
Ports the alt job titles for bitrunners from skyrat

And whilst here i also made the clown ruin actually possible to be completed solo by removing the slippery tile below bananium doors

Why It's Good For The Game

Honesly, just read the original PR's or the changelog. If i explained it all this would be a 10-20 minute copy-pasted essay.

In short: there's a lot of good stuff in those PR's

But for my changes, i think having every ruin being able to be solo'd is good. As forced cooperation is quite boring and impossible at times in low-pop

Changelog

🆑 Singul0, Melbert, Motho, jlsnow301, Rhials, Gboster
add: Motho - Bitrunners can now have alternative job titles. FTU urges that these titles are purely cosmetic and not representative of bitrunning ability.
add: Rhials - Two new psyker-oriented virtual domains -- Crate Chaos and Infected Domain.
add: Rhials - Map helper for cyber-police corpse spawn.
add: Rhials - Map helper for swapping the encrypted crate in an area with a random crate from that same area.
add: jlsnow301 - Quantum servers now look for a new machine called a byteforge to spawn loot on- no longer on an invisible landmark. This should make the rooms rebuildable after disasters.
add: jlsnow301 - Most bitrunning machinery is now researchable and buildable via circuits in the engineering protolathe.
fix: jlsnow301 - Added extra checks to bitrunning domain cleanup so avatars are deleted properly.
fix: Singul0 - Fixes missing baseturfs and clowns in mining planet VDOM.
fix: Melbert - Virtual Drink Glasses now look correct.
fix: Gboster - Makes the clown mining planet virtual plane actually able to be solved solo.
/:cl:

MrMelbert and others added 9 commits October 14, 2023 07:50
## About The Pull Request

This drinking glass subtype was runtiming like crazy because it didn't
have `base_container_type` set, meaning it ~failed the vibe check~
couldn't properly update its sprite according to the glass styles.


![image](https://github.com/tgstation/tgstation/assets/51863163/b9410fa4-e8ec-417f-ac41-e8986c754c34)

Swapped it out for a subtype of `filled`. Because it's a glass that
starts filled.

## Changelog

:cl: Melbert
fix: Virtual Drink Glasses now look correct. 
/:cl:
The next round of small changes to how bitrunning works - mostly from
feedback, bug reports etc.

- The loot crate delivery spot is now a buildable machine (the
byteforge), making it replaceable in the event of a disaster
- Same for netpods and quantum consoles. These boards are now
researchable and buildable.
- New icons for the byteforge and the health monitor
- Some bug fixes around despawning avatars
- Reimplements one of the bitrunning unit tests

<details>
<summary>Pictures ⬇️</summary>

Host monitor

![hostmon](https://github.com/tgstation/tgstation/assets/42397676/dc6811bc-7ce9-4eae-a91b-96975bd13c65)

Byteforge

![dreamseeker_LewhZG8bEl](https://github.com/tgstation/tgstation/assets/42397676/3071bc5f-b2c1-47d5-8a56-b0e6c216be20)

Spawning a crate

![dreamseeker_mHGSfoeMu5](https://github.com/tgstation/tgstation/assets/42397676/d5f84e91-b9bc-4bb8-8f1c-f8931154ff6d)
</details>

Bitrunning bug fixes and personal requests
Fixes #78571
Fixes an issue reported in discord - players stuck as gondola spawn

:cl:
fix: Added extra checks to bitrunning domain cleanup so avatars are
deleted properly.
add: Quantum servers now look for a new machine called a byteforge to
spawn loot on- no longer on an invisible landmark. This should make the
rooms rebuildable after disasters.
add: *Most* bitrunning machinery is now researchable and buildable via
circuits in the engineering protolathe.
/:cl:
## About The Pull Request

_Really? Bitrunning maps are so simple you could do them with your eyes
closed? Hmmmmm..._

This adds two new medium-difficulty virtual domains to the pool -- Crate
Chaos and Infected Domain.

These two domains take you to neglected corners of the virtual world.
These are unstable, bizarre locales that do not support the bitrunning
machine's visual display, and must be traversed using echolocation.
**_These domains have been designed around you being a psyker, and will
turn your bitrunner avatar into a psyker until they leave the domain._**

_**Crate Chaos:** Low cost, medium reward._

Sneak into an abandoned virtual domain, where they store all of the loot
crates. There's about 40-ish crates in this space, and one of them
(RANDOM) is the encrypted cache we're looking for. The crates must be
manually inspected, requiring you to drop your weapon for a few moments,
but that shouldn't be a problem. There's no hostiles, just a bunch of
crates... right?

This one has very few shenanigans or threats in it. It's meant to be an
introductory experience to interfacing with things as a psyker, and
getting the rhythm down for moving between visual pulses.

_**Infected Domain:** Medium cost, high reward._

Enter another abandoned virtual domain. This one was sealed off from the
digital world after the cyber-police failed to contain a virus that
zombified its inhabitants, leaving it to grow unstable and full of
holes. Fortunately, you're provided with the single best tool for arming
yourself against zombies in any video game, ever -- Your very own
Mystery Box. Get armed with (basically) whatever gun you want, and go
put those wacky psyker abilities to use against those zombies.

This one is a lot meaner. Many chasms, landmines, and zombies. Walk
slowly, stay with your fellow bitrunners, and if it's too hard, there's
no shame in going back and rolling for a better gun!

The domains themselves are VERY simple, since there's little need for
decor or particularly complex layouts. The idea is that you should be
able to see everything you need to see in a given room/area with a
single vision pulse. Here's what one of the maps looks like:


![image](https://github.com/tgstation/tgstation/assets/28870487/fe63adce-aa05-4339-9d19-28ce06a2d31f)

Err, uh, I mean... This is what the maps look like:

<details>
<summary>SPOILERS BEWARE</summary>
<br>


![image](https://github.com/tgstation/tgstation/assets/28870487/265ecdc5-50f6-4a28-8068-fab08ae1f5e8)


![image](https://github.com/tgstation/tgstation/assets/28870487/0b41da6a-e018-4434-9368-6daee1f97fe9)

(You wanna find out if there's something cool under those red lines? Go
there yourself!)

</details>

These two psyker maps come with their own psyker safehouse too -- The
Bathroom. It's gross, the medical supplies are kind of just sitting
there on the floor... It looks a little bit better when you're blind, I
guess.


![image](https://github.com/tgstation/tgstation/assets/28870487/a10b70bb-5586-4d37-bbb1-a642d8524d54)
## Why It's Good For The Game

I like psykers a lot more than I'm willing to admit. Unfortunately, the
jankiness of echolocation provides such a disadvantage at times, that
any "real" conflict is usually over before the psyker is even aware
they're taking damage.

Fortunately, the controlled environments that bitrunning maps are
perfect for psykers. They give the opportunity to craft an experience
around the player being blind, rather than forcing them to play blind
through a seeing mans world.

These two domains should present players with a unique challenge that is
designed around playing as a psyker, with slightly higher-than-usual
rewards for their trouble. More importantly -- They're fun!
## Changelog
:cl: Rhials
add: Two new psyker-oriented virtual domains -- Crate Chaos and Infected
Domain.
add: Map helper for cyber-police corpse spawn.
add: Map helper for swapping the encrypted crate in an area with a
random crate from that same area.
/:cl:
@dwasint dwasint merged commit 08d2216 into Monkestation:master Oct 16, 2023
19 checks passed
github-actions bot added a commit that referenced this pull request Oct 16, 2023
@Gboster-0 Gboster-0 deleted the upstream-bitrunning branch October 16, 2023 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants