Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand wire knowledge #4562

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Expand wire knowledge #4562

merged 1 commit into from
Dec 17, 2024

Conversation

Gw0sty
Copy link
Collaborator

@Gw0sty Gw0sty commented Dec 13, 2024

About The Pull Request

  • Allows robo wire knowledge to understand modsuits and mulebots

  • Allows engineer wire knowledge to understand air alarms and vending machines

Why It's Good For The Game

  • Mod suits and mulebots would both fall under roboticists' speciality and make sense for them to gain an understanding of it.
  • Air Alarms would most certainly fall under wire knowledge for engi wire knowledge
  • Vending machines are common enough that its a QOL for engineers.

Changelog

🆑
add: Engi Wire knowledge can now see Air alarms and vending machines wires
add: Robo Wire knowledge can now see Modsuit and Mulebot wires
/:cl:

@Gw0sty Gw0sty added the Minor label Dec 13, 2024
@Kmla2 Kmla2 added the QoL improves quality of life label Dec 14, 2024
@destrucktoid
Copy link

Air Alarms would most certainly fall under wire knowledge for engi wire knowledge

I disagree, this should fall under atmospherics, not engineering. I don't believe atmos techs get this skill chip so i don't think this skill chip should get the wire knowledge.

Also, what on earth would it be useful for other than for traitoring? You already get access to everything an air alarm has just from having access to it.

@Gw0sty
Copy link
Collaborator Author

Gw0sty commented Dec 16, 2024

I would argue this knowledge would not fall under atmospherics job to know the wires but engineers. For one Atmosph techs aren't even given a multitool for their job as it's not needed. Their job isn't to maintain the air alarms and other machines but to use them to assist alongside their other tools to maintain healthy air levels.

For what function it would serve an station engineer or chief engineer, the same reasons as APC knowledge given an engineer already. To be able to fix the electronics at a glance. I'd say the key wires of 'AI connection' and 'Wire power' are the greatest boon. Wire power can be used to solve shorted air alarms much in the same way shorted APC's are after a EMP or the like. And sometimes you really don't want the ai to have access to certain machines/apcs like the air alarms. And the specialist trying to find the right wire and accidentally pulsing/cutting the panic siphon wire just sucks conceptually. Its like a plumber trying to fix a clog and flooding your bathroom.

Finally as you presented engineers already have access to those machines so it doesn't particularly allow for any additional traitoring. Espically since the jobs who have access to this skillchip also have access to insuls, so they can manually learn the wires already without consequence. It's just a nice QOL thing to have that fits in with the idea of a skillchip that lets you understand the wires of a station.

@ThePooba ThePooba merged commit 5c2a1ee into Monkestation:master Dec 17, 2024
26 checks passed
github-actions bot added a commit that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Minor QoL improves quality of life
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants