-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Refactors cassettes and the cassette player #4572
Draft
Absolucy
wants to merge
15
commits into
Monkestation:master
Choose a base branch
from
Absolucy:cassette-refactor
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3,707
−3,196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Absolucy
added
do not merge
don't merge this ffs
do not testmerge
50-50 chance this gets testmerged anyways
Fix
fix da bug
Refactor/Rework
Completely redoing a larger thing / recoding a thing
labels
Dec 15, 2024
Absolucy
force-pushed
the
cassette-refactor
branch
3 times, most recently
from
December 16, 2024 02:34
20602cf
to
32b17c8
Compare
Absolucy
force-pushed
the
cassette-refactor
branch
from
December 25, 2024 21:11
32b17c8
to
59476a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
do not merge
don't merge this ffs
do not testmerge
50-50 chance this gets testmerged anyways
Fix
fix da bug
Merge Conflict
Refactor/Rework
Completely redoing a larger thing / recoding a thing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Why It's Good For The Game
Changelog
🆑
refactor: Rewrote large chunks of cassette / cassette player code.
/:cl: