Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More antag symbols + Theseus map fixes #4715

Merged
merged 8 commits into from
Dec 31, 2024
Merged

Conversation

Gw0sty
Copy link
Collaborator

@Gw0sty Gw0sty commented Dec 28, 2024

About The Pull Request

Why It's Good For The Game

The Antagonist symbol is a nice QOL for admins letting them spot different antags visually at a glance. These three noticeably were missing/did not have a symbol.

Medium threat cortical borers, the reproducing ones, now show as "hivemind cortical borers" to differentiate between the two. Allowing to know the difference between the two in the traitor panel and spend antag tokens panels.

Moved Contractor support Units from Traitor section to the Drifting Contractor section

Moved a silly mistake by me creating unnessecary folders :P.

Changelog

🆑
add: Added missing Antag symbols for Space Ninja, Contractor, Florida Man.
qol: Medium threat Cortical borer's are now labeled as "Hivemind Cortical Borer" in information and panels
fix: Theseus's virology disposals now leads to space instead of maintenance.
fix: Theseus's NT rep should now be able to use their bathroom without the blueshield's help.
fix: Theseus's captain and blueshield room should have functional curtain and blast door buttons.
fix: Theseus's xenobiology ooze suckers now all function
fix: Theseus's genetics now has data disk boxes instead of Nitrile gloves
/:cl:

@Gw0sty Gw0sty added QoL improves quality of life spriting labels Dec 28, 2024
@Gw0sty Gw0sty changed the title More antag symbols More antag symbols + Theseus map fixes Dec 28, 2024
Copy link
Collaborator

@Kitsunemitsu Kitsunemitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would legitimately recommend atomizing this.
Theseus and antag symbols do not belong in the same PR; it should be made into two separate PRs.

Merging two PRs that do one specific thing is much cleaner than merging one PR that does 2 entirely unrelated things.

@DexeeXI
Copy link
Collaborator

DexeeXI commented Dec 29, 2024

Remember, if you state Fixes [issue#], it will auto add that to the pane.

I'll manually assign what it will fix.

@MomoBerri
Copy link
Contributor

I'm glad you did fixes for theseus, but atomization is definitely important.

@Absolucy Absolucy merged commit 4f41a16 into Monkestation:master Dec 31, 2024
30 checks passed
github-actions bot added a commit that referenced this pull request Dec 31, 2024
Gw0sty added a commit to Gw0sty/Monkestation2.0 that referenced this pull request Jan 9, 2025
* Antag symbols Yipeeeee

* Moving blob file

* ticked files go brrrr

* Thesues mapping issues

* More thesues stuff

* testing fixes

* mapping on laptop ;-;
Gw0sty pushed a commit to Gw0sty/Monkestation2.0 that referenced this pull request Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment