Oozling Gibbing Patch

[Coll6]

About The Pull Request

All this does is remove the gibbing check to delete Oozling cores if their body was gibbed. It remains the DNA check so most occurrences of Oozling cores without souls are now gone. This also makes it so cores when destroyed properly eject their items or delete. Throw a core at a SM watch it pop like a loot pinata! Finally just adds in some GC that was left out.

Why It's Good For The Game

I had assumed the code was consistent and reliable enough to count on the gibbed = true flag to reflect what it meant. Turns out this is not the case. This ends up causing Oozlings to be RR'd from more unintended sources than other species. I am working on a proper fix so there are some things that won't gib an Oozling. However, for things like explosions, and other body destroying situations you should see the expected core removal. If the core doesn't get removed you can still just destroy it and get everything inside. Still a proper fix is being worked on, in the meantime this should handle most situations.

GC is always a good thing.

Changelog

🆑
del: Hard gibbed flag check
code: Removes cores from bodies that do not save DNA.
add: Core deletions will properly drop items in most cases. If core is in nullspace they will be qdel instead.
/:cl:

[F-e-r-n]

HOW MANY COMMITS? Looking into this though

[F-e-r-n]

Looking for a better way to do this, as we still want gibbing to remove brains when prompted.

[Coll6]

Looking for a better way to do this, as we still want gibbing to remove brains when prompted.

Oh sorry only one commit in this. I didn't understand how my PR being merged would work if I was on the same branch, Mistake on my part I can clean it up but since it removes a change I made in that PR ya know. I am working on a solution. I would like to know if anyone can tell me why we add a timer for core ejection instead of just calling it immediately on stat change. I have ideas but it's hard to know why some things are the way they are and it makes mistakes like this.

I do have an idea of causes but I need a consistent pattern of what causes gibbing and what that does to both the core and brain. Last part I have handled but I can't even imagine the list of ways to gib someone.

[F-e-r-n]

Oh sorry only one commit in this. I didn't understand how my PR being merged would work if I was on the same branch, Mistake on my part I can clean it up but since it removes a change I made in that PR ya know. I am working on a solution. I would like to know if anyone can tell me why we add a timer for core ejection instead of just calling it immediately on stat change. I have ideas but it's hard to know why some things are the way they are and it makes mistakes like this.

I do have an idea of causes but I need a consistent pattern of what causes gibbing and what that does to both the core and brain. Last part I have handled but I can't even imagine the list of ways to gib someone.

Now that I think about it, the easiest way to handle this might be just to leave gibbing as it is normally, as I believe your core counts as your brain anyways unless there's a proc in there that "activates" the core so to speak. I'll look into it.

[Coll6]

Oh sorry only one commit in this. I didn't understand how my PR being merged would work if I was on the same branch, Mistake on my part I can clean it up but since it removes a change I made in that PR ya know. I am working on a solution. I would like to know if anyone can tell me why we add a timer for core ejection instead of just calling it immediately on stat change. I have ideas but it's hard to know why some things are the way they are and it makes mistakes like this.
I do have an idea of causes but I need a consistent pattern of what causes gibbing and what that does to both the core and brain. Last part I have handled but I can't even imagine the list of ways to gib someone.

Now that I think about it, the easiest way to handle this might be just to leave gibbing as it is normally, as I believe your core counts as your brain anyways unless there's a proc in there that "activates" the core so to speak. I'll look into it.

Thing is you cant rely on this. At the moment this RR oozlings because the chasm death proc is death(1) which means the death was caused by gibbing. I am sure there may me more cases like this. Like everything else in #4343 it was just attempting to add checks to bring behavior closer to what we expect to humans. The whole core ejection needs something a little similar.

[F-e-r-n]

Oh sorry only one commit in this. I didn't understand how my PR being merged would work if I was on the same branch, Mistake on my part I can clean it up but since it removes a change I made in that PR ya know. I am working on a solution. I would like to know if anyone can tell me why we add a timer for core ejection instead of just calling it immediately on stat change. I have ideas but it's hard to know why some things are the way they are and it makes mistakes like this.
I do have an idea of causes but I need a consistent pattern of what causes gibbing and what that does to both the core and brain. Last part I have handled but I can't even imagine the list of ways to gib someone.

Now that I think about it, the easiest way to handle this might be just to leave gibbing as it is normally, as I believe your core counts as your brain anyways unless there's a proc in there that "activates" the core so to speak. I'll look into it.

Thing is you cant rely on this. At the moment this RR oozlings because the chasm death proc is death(1) which means the death was caused by gibbing. I am sure there may me more cases like this. Like everything else in #4343 it was just attempting to add checks to bring behavior closer to what we expect to humans. The whole core ejection needs something a little similar.

Hmm, good point. Honestly chasm deaths should probably be their own death type, but that's a whole other topic. I'll bring this pr up with pooba and talk about it with them.