Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BOUNTY] Port Skyrat's feature to be able to play the character we want in a ghost role (using character loadouts #4783

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Singul0
Copy link
Contributor

@Singul0 Singul0 commented Jan 7, 2025

About The Pull Request

Ports Skyrat-tg/#11175, the feature of importing your loaded character preferences to your ghost role you're spawning as.
Currently, most human away ghost roles gets this feature. (hermit, syndie, charliestation, etc)

Why It's Good For The Game

More customization --> more roleplay oppurtunity --> more fun

Changelog

S1ngulo, BingusSS13 🆑
add: You can customize ghost roles you spawn as, using your loaded character preferences
/:cl:

@Singul0 Singul0 changed the title [BOUNTYPort Skyrat's feature to be able to play the character we want in a ghost role (using character loadouts [BOUNTY] Port Skyrat's feature to be able to play the character we want in a ghost role (using character loadouts Jan 7, 2025
@Singul0
Copy link
Contributor Author

Singul0 commented Jan 7, 2025

Also, do we want to open character prefs races to the ghost role races too? (ashwalker, podpeople) solely for them to be able to customize their own character. I can add that, but I fear that it might clog up the race selection menu

@Shoddd
Copy link
Collaborator

Shoddd commented Jan 7, 2025

not sure who you are on discord but don't seem to be aware. There is #4646 which seems to be about the same thing just bringing it to your attention

@Singul0
Copy link
Contributor Author

Singul0 commented Jan 7, 2025

Ah shucks oh well

Edit: nevermind, headmaint told to talk things off with both of us

@Singul0 Singul0 closed this Jan 7, 2025
@Singul0 Singul0 reopened this Jan 7, 2025
@Singul0
Copy link
Contributor Author

Singul0 commented Jan 8, 2025

Talked to the other guy, I managed to port over their fixes from the test merges. did a good number of tests too. we are fine with either PR's getting merged since both fulfill the bounties anyways.

This one has working plasmamen's, though they default to the standard orange protective suits

@Kitsunemitsu Kitsunemitsu added Major QoL improves quality of life labels Jan 9, 2025
@Shoddd
Copy link
Collaborator

Shoddd commented Jan 10, 2025

I do think this one should be merged over the other one since it has the option to disable loadout items inside

@Absolucy
Copy link
Member

@Singul0 does that commit fix #4840

@Singul0
Copy link
Contributor Author

Singul0 commented Jan 15, 2025

@Singul0 does that commit fix #4840

Yep, affirm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Major QoL improves quality of life
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants