[DNM] Icon and filter optimization stuff #4825
Open
+58
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Absolucy
added
the
Performance / Optimization
Absolucy
changed the title
|
DNM until it's far more extensively tested and profiled (on production, via being testmerged) |
This was referenced Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Ports my own upstream PR, tgstation/tgstation#88986
I also made it cache mask icons for height filters, and at the suggestion of smartkar, replaced
if(!(appearance.appearance_flags & KEEP_TOGETHER))withif((appearance.appearance_flags & KEEP_APART) && !(appearance.appearance_flags & RESET_TRANSFORM))also fixed "lengthen" being spelled as "lenghten"
Why It's Good For The Game
less filter and height-related lag and overtime, hopefully.
Changelog
🆑
fix: Optimized some code related to filters and mob height.
/:cl: