Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve admin logging for antag/event tokens #4979

Merged
merged 1 commit into from
Jan 19, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 24 additions & 8 deletions code/modules/admin/topic.dm
Original file line number Diff line number Diff line change
Expand Up @@ -1781,8 +1781,12 @@
if(!IS_CLIENT_OR_MOCK(target))
return
var/client/user_client = target
user_client.client_token_holder.approve_antag_token()
log_admin("[user_client]'s token has been approved by [owner].")
var/datum/meta_token_holder/token_holder = user_client?.client_token_holder
if(!token_holder?.in_queue)
return
token_holder.approve_antag_token()
message_admins("[key_name_admin(owner)] approved a [token_holder.in_queue] token from [ADMIN_LOOKUPFLW(user_client)]")
log_admin("[user_client]'s [token_holder.in_queue] token has been approved by [owner].")

else if(href_list["reject_antag_token"])
if(!check_rights(R_ADMIN))
Expand All @@ -1791,8 +1795,12 @@
if(!IS_CLIENT_OR_MOCK(target))
return
var/client/user_client = target
user_client.client_token_holder.reject_antag_token()
log_admin("[user_client]'s token has been rejected by [owner].")
var/datum/meta_token_holder/token_holder = user_client?.client_token_holder
if(!token_holder?.in_queue)
return
token_holder.reject_antag_token()
message_admins("[key_name_admin(owner)] rejected a [token_holder.in_queue] token from [ADMIN_LOOKUPFLW(user_client)]")
log_admin("[user_client]'s [token_holder.in_queue] token has been rejected by [owner].")

else if(href_list["open_music_review"])
if(!check_rights(R_ADMIN))
Expand All @@ -1810,8 +1818,12 @@
if(!IS_CLIENT_OR_MOCK(target))
return
var/client/user_client = target
user_client.client_token_holder.approve_token_event()
log_admin("[user_client]'s token event has been approved by [owner].")
var/datum/meta_token_holder/token_holder = user_client?.client_token_holder
if(!token_holder?.queued_token_event)
return
token_holder.approve_token_event()
message_admins("[key_name_admin(owner)] approved a [token_holder.queued_token_event.event_name] event token from [ADMIN_LOOKUPFLW(user_client)]")
log_admin("[user_client]'s [token_holder.queued_token_event.event_name] event token has been approved by [owner].")

else if(href_list["reject_token_event"])
if(!check_rights(R_ADMIN))
Expand All @@ -1820,6 +1832,10 @@
if(!IS_CLIENT_OR_MOCK(target))
return
var/client/user_client = target
user_client.client_token_holder.reject_token_event()
log_admin("[user_client]'s token event has been rejected by [owner].")
var/datum/meta_token_holder/token_holder = user_client?.client_token_holder
if(!token_holder?.queued_token_event)
return
token_holder.reject_token_event()
message_admins("[key_name_admin(owner)] rejected a [token_holder.queued_token_event.event_name] event token from [ADMIN_LOOKUPFLW(user_client)]")
log_admin("[user_client]'s [token_holder.queued_token_event.event_name] event token has been rejected by [owner].")
//monkestation edit end
Loading