Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dagoth Smite #501

Merged
merged 7 commits into from
Nov 5, 2023
Merged

Dagoth Smite #501

merged 7 commits into from
Nov 5, 2023

Conversation

DexeeXI
Copy link
Collaborator

@DexeeXI DexeeXI commented Oct 28, 2023

About The Pull Request

I said I wanted it, I said I was gonna do it, and here it is! The biblefart code made into SMITE! form, with some small tweaks to help with the "fun" aspect. In the event someone really does a horrible prayer or people beg to be struck down, the admemes will have another tool in the toolbox to expand the fun.

Now includes a non lethal option as well, clearly marked.

Why It's Good For The Game

More RP possibilities!

Changelog

🆑
add: Dagoth Ur wishes you all to behave yourselves and pray well, lest you invoke his anger.
/:cl:

@wraith-54321
Copy link
Collaborator

Please add this to the smite spell as well, should just be adding it to a list or two.

var/mob/living/carbon/human/Person = target
var/turf/Location = get_turf(target)
var/turf/T = get_step(get_step(Person, NORTH), NORTH)
to_chat(Person,"<span class='ratvar'>What a grand and intoxicating innocence. Perish.</span>")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
to_chat(Person,"<span class='ratvar'>What a grand and intoxicating innocence. Perish.</span>")
to_chat(Person, span_ratvar("What a grand and intoxicating innocence. Perish."))

try to use span procs(technically macros) wherever possible.

var/turf/Location = get_turf(target)
var/turf/T = get_step(get_step(Person, NORTH), NORTH)
to_chat(Person,"<span class='ratvar'>What a grand and intoxicating innocence. Perish.</span>")
T.Beam(Person, icon_state="lightning[rand(1,12)]", time = 15)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
T.Beam(Person, icon_state="lightning[rand(1,12)]", time = 15)
T.Beam(Person, icon_state="lightning[rand(1,12)]", time = 1.5 SECONDS)

Use SECONDS procs for time related things.

name adjusted to be plainly obvious that one kills. added a second one that just plain strips'm and drops'm to the floor.
@DexeeXI
Copy link
Collaborator Author

DexeeXI commented Nov 1, 2023

Renamed, added a command that just straight strips them, with text.

@dwasint dwasint merged commit d1c154d into Monkestation:master Nov 5, 2023
20 checks passed
github-actions bot added a commit that referenced this pull request Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants