Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix monke coin rewards for patreon members #503

Merged
merged 4 commits into from
Nov 5, 2023

Conversation

SeaPlusPlush
Copy link
Contributor

@SeaPlusPlush SeaPlusPlush commented Oct 28, 2023

About The Pull Request

Metacoins do not properly update for donators due to the code block being out of order. It will say you receive extra coins but you really only get the default amount. Rearranged the block and it should be fixed now

image

Why It's Good For The Game

Give proper patreon rewards

Changelog

🆑 Senri
fix: Fixed patreon monkecoin boost to work properly
/:cl:

@SeaPlusPlush
Copy link
Contributor Author

SeaPlusPlush commented Oct 29, 2023

tested how current code works with a round:

  • end of round gain 225mc (75mc * 3 for nukie patreon tier)
  • opened char prefs before server restart
  • monkecoin balance shows +225mc
  • server restarts
  • monkecoin balance is only +75mc

so yeah, code needs to run sql statement after donator mult is applied

@dwasint dwasint merged commit 3a814f6 into Monkestation:master Nov 5, 2023
21 checks passed
github-actions bot added a commit that referenced this pull request Nov 5, 2023
@SeaPlusPlush SeaPlusPlush deleted the FIx-MonkeCoin-Generation branch November 26, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants