Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security Liability Act #562

Closed
wants to merge 9 commits into from
Closed

Security Liability Act #562

wants to merge 9 commits into from

Conversation

Bidlink1
Copy link
Contributor

@Bidlink1 Bidlink1 commented Nov 15, 2023

About The Pull Request

Adds body cameras to security, captain, warden, and HOS lockers that are attachable to armor that has a slot (most armors do). Thanks to johnfulpwillard for the help and the code!

Why It's Good For The Game

allows better Security coordination and gives the warden's job a bit more spice as they can use their camera console to coordinate security operatives while they wait for prisoners.

Changelog

🆑
add: Adds in Body cameras and adds them to security related lockers
qol: made something easier to use
balance: AIs and sec get a small buff using this, Ai can see out of the camera's
image: Body camera sprites
admin: Body Camera item name is 'bodycam_upgrade'
/:cl:

@Bidlink1
Copy link
Contributor Author

SHIT I FUCKED UP, I ACCIDENTALLY DID TWO PR'S AA

@Bidlink1 Bidlink1 closed this Nov 15, 2023
@Bidlink1 Bidlink1 reopened this Nov 15, 2023
@Camriod
Copy link
Contributor

Camriod commented Nov 17, 2023

holy shit it's beautiful

@dwasint
Copy link
Collaborator

dwasint commented Nov 18, 2023

needs to be modularized into monkestation folder

@DexeeXI
Copy link
Collaborator

DexeeXI commented Dec 15, 2023

Noting that this PR now has MERGE CONFLICT and must be resolved.

However, the last action on this was a month ago. Going to recommend closure of this PR to @dwasint and @wraith-54321 until further action is taken.

Copy link
Contributor

@JohnFulpWillard JohnFulpWillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish I found a better way to do it than this hacky workaround but if I ever do change it then I hope it gets ported here too

@@ -0,0 +1,145 @@

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should try to avoid using capital letters in file names

Comment on lines +2 to +8
/obj/item/clothing/suit/armor/Initialize(mapload)
. = ..()
AddComponent(/datum/component/bodycamera_holder)

/obj/item/clothing/suit/hooded/wintercoat/security/Initialize(mapload)
. = ..()
AddComponent(/datum/component/bodycamera_holder)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could maybe move these to some other overwrite file, up to personal choice but it might look a little confusing to have this Initialize here



/**
* Bodycamera component
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should move this component to a new file, it would be like bodycamera_item.dm and bodycamera_component.dm

@Bidlink1 Bidlink1 closed this by deleting the head repository Feb 27, 2024
@JohnFulpWillard
Copy link
Contributor

:(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants