-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Security Liability Act #562
Conversation
SHIT I FUCKED UP, I ACCIDENTALLY DID TWO PR'S AA |
holy shit it's beautiful |
needs to be modularized into monkestation folder |
Noting that this PR now has MERGE CONFLICT and must be resolved. However, the last action on this was a month ago. Going to recommend closure of this PR to @dwasint and @wraith-54321 until further action is taken. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish I found a better way to do it than this hacky workaround but if I ever do change it then I hope it gets ported here too
@@ -0,0 +1,145 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should try to avoid using capital letters in file names
/obj/item/clothing/suit/armor/Initialize(mapload) | ||
. = ..() | ||
AddComponent(/datum/component/bodycamera_holder) | ||
|
||
/obj/item/clothing/suit/hooded/wintercoat/security/Initialize(mapload) | ||
. = ..() | ||
AddComponent(/datum/component/bodycamera_holder) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could maybe move these to some other overwrite file, up to personal choice but it might look a little confusing to have this Initialize here
|
||
|
||
/** | ||
* Bodycamera component |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should move this component to a new file, it would be like bodycamera_item.dm
and bodycamera_component.dm
:( |
About The Pull Request
Adds body cameras to security, captain, warden, and HOS lockers that are attachable to armor that has a slot (most armors do). Thanks to johnfulpwillard for the help and the code!
Why It's Good For The Game
allows better Security coordination and gives the warden's job a bit more spice as they can use their camera console to coordinate security operatives while they wait for prisoners.
Changelog
🆑
add: Adds in Body cameras and adds them to security related lockers
qol: made something easier to use
balance: AIs and sec get a small buff using this, Ai can see out of the camera's
image: Body camera sprites
admin: Body Camera item name is 'bodycam_upgrade'
/:cl: