Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always Compile On Build #564

Closed

Conversation

SeaPlusPlush
Copy link
Contributor

About The Pull Request

Always compile when you build (f5) rather than the random mess we have now.

Changelog

🆑 Senri
qol: for developers - build should always compile now, no more fake compiling
/:cl:

@wraith-54321
Copy link
Collaborator

Will this still allow tgui to be skipped?

@SeaPlusPlush
Copy link
Contributor Author

As far as I am aware, no, but I did not do extensive testing into tgui runtimes.

When you press f5 the build.bat file is ran. The build.bat file runs the build.js file listed here. I am not certain if they are called outside of when you are building the project.

It essentially just overrides the if statement here to make it as if an argument is always passed and thus the return[] line is triggered, but I chose to do it via commenting out the whole block.
image

@Absolucy
Copy link
Member

Absolucy commented Jan 7, 2024

#877 fixes this properly

@dwasint dwasint closed this in #877 Jan 9, 2024
@SeaPlusPlush SeaPlusPlush deleted the always_compile branch March 31, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants