[Mirror] animates the *jump, *shiver, *sway, *tremble, *twitch and *twitch_s emotes #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…motes (#75345) ## About The Pull Request Using the *jump, *shiver, *sway, *tremble, *twitch or *twitch_s emote will now animate the position of your character for a little bit. Also the *jump emote plays a sound now. The effects can be seen [here](https://youtu.be/tCoAOrHJbNg). The *jump sound has been changed, it now sounds like this: https://github.com/tgstation/tgstation/assets/94711066/8ee92429-7c94-4a11-a8c1-972b305b1d9f ## Why It's Good For The Game Having these emotes actually display on your character makes them a bit more lively. ## Changelog :cl: add: added animations to the *jump, *shiver, *sway, *tremble, *twitch and *twitch_s emotes add: the *jump emote now plays a sound /:cl: --------- Co-authored-by: san7890 <[email protected]>
WHAT HAS CHANGED MECHANICALLY You can now lean up against walls. https://github.com/tgstation/tgstation/assets/55666666/bf81b7b5-6cab-4fc3-9887-075351511505 To lean against a wall, simply face opposite to it and drag your sprite onto it. Doing so makes you non-dense, just like if you were laying down. This means people can walk through you, but you are still susceptible to melee and ranged attacks. Leaning up against a wall also mitigates your FOV loss by 30 degrees, as you can have a better look at your surrounding when you put more of your surroundings infront of you. Because it seemed thematic to lean up against the wall while smoking and then flick a cigarette away, cigarettes will now say they where "flicked" instead of thrown when you toss them, I also took the time to add a bit of variation into the throw text. A few bugs where you could become non dense and then run straight through people has been patched. NOT PLAYER FACING So basically I've implemented a system that keeps effects that manage a mob's density consistent with eachother. An example of some of the situations that could occur Effect A would render a spaceman undense and turn the player dense again once it was concluded Effect B would render a spaceman undense and then after a timer revert the spaceman to whatever state the spaceman was in before effect B started. Thus if you enabled effect A and then Effect B, setting your previous state of denseness to undense, and then concluded effect A, when Effect B would finish it would put you back into the state of density you were in when you started. This would render the spaceman permanently undense. To solve this, the system has been updated so that all instances of density adjustment to mobs are handled by traits from unique sources (with the exception undensity gained by laying down due to its prevalence.) All effects that handle density will no longer step on each others toes and can now be rain simultaneously without fear. Leaning is cool. Bugs are bad. :cl: itseasytosee add: You can now lean against walls! Simply turn your back to the wall and clickdrag yourself onto it. fix: There should no longer be any instances of spacemen being able to run straight through eachother as if they weren't even there. spellcheck: Added more variance to item throwing text. refactor: Mob density has been refactored /:cl:
This reverts commit 7fa71cb.
Gboster-0
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: tgstation/tgstation#75345
About The Pull Request
Using the *jump, *shiver, *sway, *tremble, *twitch or *twitch_s emote will now animate the position of your character for a little bit. Also the *jump emote plays a sound now. The effects can be seen here.
The *jump sound has been changed, it now sounds like this:
https://github.com/tgstation/tgstation/assets/94711066/8ee92429-7c94-4a11-a8c1-972b305b1d9f
Why It's Good For The Game
Having these emotes actually display on your character makes them a bit more lively.
Changelog
🆑 kawoppi, gboster
add: kawoppi: added animations to the *jump, *shiver, *sway, *tremble, *twitch and *twitch_s emotes
add: kawoppi: the *jump emote now plays a sound
/:cl: