Various Timestop Guardian bug fixes #718
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…locked to Bloodsuckers as intended Timestop Guardian was inadvertantly changed to overwrite the Standard Guardian in a767b9f; this fixes that
…s effects A more detailed look at whether it should be timestopping the master will be done later. For now, it is, so we describe it as such.
|
After talking with Kilgor and Dexee, we've decided to try to roll the Timestop Guardian into the normal traitor list - with the Bloodsucker still being locked into the Timestop Guardian, because haha funny anime reference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Timestop Guardian was originally intended to be locked to Bloodsuckers. However, due to a (presumably accidental) change made in the commit a767b9f, Timestop Guardian ended up overwriting Standard Guardian.
While players could still choose other guardian types, the Timestop Guardian has fairly overpowered abilities, making it a very easy choice compared to anything else.
In the process of fixing and testing this, I found a couple other errors; namely, the timestop's description is wrong; and that Bloodsuckers would be offered a useless Guardian Type selection - despite the guardian type then being overwritten if you were a Bloodsucker. These have been fixed.
I plan to work with Dexee to refactor/modularize Guardians as a whole, at a later date. However, these bug fixes are important now.
Why It's Good For The Game
Fixes dat fuggin Timestop Guardian.
Changelog
🆑 MichiRecRoom
fix: Timestop Guardian no longer overwrites the Standard Guardian, which additionally restricts Timestop Guardian to Bloodsuckers (as was intended)
fix: Guardian Timestop spell incorrectly stated that the master was exempt from the Timestop field
/:cl: