Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No voting for you #729

Merged
merged 15 commits into from
Dec 19, 2023
Merged

No voting for you #729

merged 15 commits into from
Dec 19, 2023

Conversation

wraith-54321
Copy link
Collaborator

@wraith-54321 wraith-54321 commented Dec 16, 2023

About The Pull Request

Reverts the equip changes to make them not bork nodrop things.
Storyteller is now random and secret at above 25 pop.
ports: tgstation/tgstation#79104

Why It's Good For The Game

Changelog

🆑 vinylspiders
fix: quick equip is disabled while its being redone to not be broken.
change: storytellers are no longer votable past a certain population and its hidden
/:cl:

@DexeeXI

This comment was marked as resolved.

@wraith-54321
Copy link
Collaborator Author

YOU DO NOT GET AN OPINION

@DexeeXI
Copy link
Collaborator

DexeeXI commented Dec 16, 2023

I was one of the ones ASKING for this!

@Gboster-0
Copy link
Contributor

would be nice for the storyteller to get announced post-round when its secret. But otherwise the only minor nitpick i can see is that the changelog does not mention the quick-equip fix

Copy link
Collaborator

@dwasint dwasint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm will TM

@dwasint dwasint merged commit 1b7c9f2 into Monkestation:master Dec 19, 2023
13 of 19 checks passed
@wraith-54321 wraith-54321 deleted the no-vote branch December 22, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants