-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No voting for you #729
Merged
Merged
No voting for you #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
YOU DO NOT GET AN OPINION |
I was one of the ones ASKING for this! |
would be nice for the storyteller to get announced post-round when its secret. But otherwise the only minor nitpick i can see is that the changelog does not mention the quick-equip fix |
dwasint
approved these changes
Dec 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm will TM
This was referenced Dec 17, 2023
This was referenced Dec 18, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Reverts the equip changes to make them not bork nodrop things.
Storyteller is now random and secret at above 25 pop.
ports: tgstation/tgstation#79104
Why It's Good For The Game
Changelog
🆑 vinylspiders
fix: quick equip is disabled while its being redone to not be broken.
change: storytellers are no longer votable past a certain population and its hidden
/:cl: