Fixes double null rod, and generally cleans up and reblanaces some pathology stuff #743
Conversation
|
The null rod change I can more or less agree with. Just seems to tweak logic so that it doesn't dupe them in the event of OOPS ALL CHAPLAIN. The vomit changes would have to be something I take a further detailed look into to fully understand what it is it is changing and to ensure that, at least regarding the one for the robots, it will still do what is intended. Now far as the carp suit.... that may have to require a much longer discussion as removing it from the store may stop anyone else further buying it at least, so it isn't going to remove it from the few people (myself included pre admin) that had bought it in the past. But I feel that there needs to be a much more deep discussion before that goes through. |
| sleep(10 SECONDS) | ||
| mob.visible_message(span_danger("[mob] vomits up blood!"), span_danger("You vomit up blood!")) | ||
| var/obj/effect/decal/cleanable/blood/S = new(loc = get_turf(mob)) |
There was a problem hiding this comment.
this shouldn't be removed so it can trigger on things with no hunger without causing massive issues
KittyNoodle
changed the title
| @@ -249,6 +215,7 @@ | |||
| to_chat(mob, span_notice("You are glowing!")) | |||
| flavortext = 1 | |||
| mob.set_light(multiplier, multiplier, multiplier/3, l_color = color) | |||
| */ | |||
There was a problem hiding this comment.
you need to comment out the deactivate aswell or it will not compile
About The Pull Request
Fixes the ancient double null rod bug that was introduced with cryopods
Pathologies two vomiting symptoms now follow the normal restrictions of vomiting symptoms.
Probably more stuff in the future
Changeling virus cure works again.
Pro-tagonista hair color change no longer effects ethereals(it was flickering and weird).
Eye watering now makes you cry
Cleans up so much symptom code.
Symptom threat level changes:
Teratoma FLAVOR => HARMFUL
Eldritch Mind HARMFUL => ANNOYING
Abductor Syndrome HELPFUL => FLAVOR
Delightful Effect HELPFUL => FLAVOR
Magnitis HARMFUL => DEADLY
Retrovirus ANNOYING => HARMFUL
Why It's Good For The Game
The double null rod thing is a bug and needs no explanation for being removed.
Although if one is needed anyway i will say there is a null rod that gives huge amounts of block, and you can double that up with another nullrod for insane combat advantage.
As for the carp suit, it is a zero-slowdown emergency firesuit that also makes all carps allied with you.
For reference the only other items in loadout with comparable power would be the wallet and maybe HP+ gum.
Consistency on vomiting is good.
Pathogens being sterilized at boiling point made way more sense than them being sterilized at an arbitrary high number.
Pierrot's throat causing motion sickness and mass babel was actually not fun.
Being able to turn rats into demon heart factories was a bit unbalanced.
The clown mask from Pierrot's throat happening at base level sucked.
Changelog
🆑
code: cleaned up a lot of pathology code
fix: changeling virus cure works again
fix: hardlight spears emit light mid-flight(my bad guys)
fix: Pro-tagonista Syndrome no longer causes ethereal hair to "flicker"
add: Eye watering makes you cry
balance: Teratomas now cause you harm
balance: Pathogen sterilization heat moved from 726.85C to 100C
balance: Pierrot's Throat no longer gives clown mask until level 2 multiplier.
balance: Changes a lot of the threat levels on symptoms
qol: Pierrot's Throat no longer gives mushroom hallucinogen
qol: Space Adaption Effect now has a better description
fix: Chaplains no longer get two null rods(test your code)
fix: Those who could not normally vomit no longer vomit with new pathology symptoms.
/:cl: