Bomber-type logs now mention if the bomber has the pacifist trait. #823
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
The Pacifist quirk is supposed to prevent you from harming creatures. In most cases, it works - the character will refuse to attack with lethal objects or lethally-loaded guns, as well as silly stuff like not stomping cockroaches.
However, it's possible for the player to bypass this pacifism. One way is through grenade-type items.
This PR doesn't block players from using grenades if they're pacifist, but it DOES cause logs to mark if they were a pacifist at the time of priming the grenade.
Note the
(pacifist)
and(while pacifist)
added near the beginning of these logs. These appear if the user has the Pacifist trait. Users without the Pacifist trait have the same logs as before.This PR also makes a small change to c4 explosives - now they're logging using the proper method instead of manually logging.
Why It's Good For The Game
Pacifist characters shouldn't be using dangerous items! While this doesn't block them from using them, it makes it much easier for admins to spot whether a player was pacifist at the time of priming a grenade - from there, the admin can tell if a pacifist player used said grenade in a non-pacifist way.
Changelog
🆑 MichiRecRoom
admin: Admin logs that relate to priming grenades or planting bombs will now contain "(pacifist)" or "(while pacifist)" near the beginning of the log, if the mob had the Pacifist trait at the time of the log being generated.
code: log_bomber() now has a new targeted variant, which should be used whenever a bomb has a target (such as with C4 or X4, which are used on mobs or turfs, rather than primed and thrown like grenades).
/:cl: