Various things #904
Merged
Various things #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converts all logging, excluding perf and investigate, to json. I focused on making the system as easy to use and as easy to add new categories as possible. Due to issues related to logging to world at global creation logger is now a byond real, which is created directly before Master Log categories support versioning, secret flagging, and sub-category filtering. Although all of this is entirely optional for coders. If you ever want to add a new category and use it, all you need to do is make the barebones category datum and the define. I've kept existing procs such as log_game, and simply turned them into a wrapper for Logger.Log(xxx, ...) Makes processing and filtering logs much easier in the future, while only minimally downgrading log crawling experience. I am also working on a log viewer frontend for admin usage however that will take a little bit longer to finish up. Also makes special logging and data tracking much easier thanks to a data list processing implementation and handling :cl: server: All logs are now formatted in json, excluding perf and investigations /:cl: --------- Signed-off-by: GitHub <[email protected]> Co-authored-by: tattle <[email protected]> Co-authored-by: Kyle Spier-Swenson <[email protected]> Co-authored-by: GoldenAlpharex <[email protected]>
See title. Surgery hud is exempt from this. Requested by @Mothblocks Signed-off-by: GitHub <[email protected]> Co-authored-by: Mothblocks <[email protected]> Co-authored-by: dragomagol <[email protected]>
…e too (#75617)   I promised I would add it; and while it's not as nice as my previous iteration it is faster and more streamlined. :cl: admin: new log viewer, try it out. (View Round Logs) /:cl: Fixes #75605 --------- Co-authored-by: san7890 <[email protected]>
- Removes unnecessary real global vars. - Adds comments pointing to the init order defined in /code/game/world.dm. - Prevent people using `GLOBAL_REAL_VAR` and `GLOBAL_REAL` to circumvent init order. - Properly type `PROFILE_STORE` real global. - Refactored `make_datum_references_lists()` and moved the call to it into `GLOB` init with duct tape. - Renamed `GLOB.admin_log` to `GLOB.admin_activities` as it wasn't actually a log file. - Whitelist loading happens in config. - Renamed `SSdbcore`'s `SetRoundID()` to `InitializeRound()`. Now handles calling `CheckSchemaVersion()`. - Created macro for setting up log `GLOB`s. - Removed log line for `GLOB` count. - Moved call to `make_datum_reference_lists()` to `/datum/controller/global_vars/Initialize()`. I slimmed it down where possible too. - Updated comments about world init order. - Move `load_admins()` call to after log setup. - Removes unused function `gib_stack_trace()`. - Removes a bunch of unused log `GLOB`s. - Unlocks the secrets of the universe by finally making the first executed line of code deterministic. No functional changes. Closes #74792 Testmerge thoroughly. --------- Co-authored-by: Mothblocks <[email protected]>
Converts all logging, excluding perf and investigate, to json. I focused on making the system as easy to use and as easy to add new categories as possible. Due to issues related to logging to world at global creation logger is now a byond real, which is created directly before Master Log categories support versioning, secret flagging, and sub-category filtering. Although all of this is entirely optional for coders. If you ever want to add a new category and use it, all you need to do is make the barebones category datum and the define. I've kept existing procs such as log_game, and simply turned them into a wrapper for Logger.Log(xxx, ...) Makes processing and filtering logs much easier in the future, while only minimally downgrading log crawling experience. I am also working on a log viewer frontend for admin usage however that will take a little bit longer to finish up. Also makes special logging and data tracking much easier thanks to a data list processing implementation and handling :cl: server: All logs are now formatted in json, excluding perf and investigations /:cl: --------- Signed-off-by: GitHub <[email protected]> Co-authored-by: tattle <[email protected]> Co-authored-by: Kyle Spier-Swenson <[email protected]> Co-authored-by: GoldenAlpharex <[email protected]>
…e too (#75617)   I promised I would add it; and while it's not as nice as my previous iteration it is faster and more streamlined. :cl: admin: new log viewer, try it out. (View Round Logs) /:cl: Fixes #75605 --------- Co-authored-by: san7890 <[email protected]>
Converts all logging, excluding perf and investigate, to json. I focused on making the system as easy to use and as easy to add new categories as possible. Due to issues related to logging to world at global creation logger is now a byond real, which is created directly before Master Log categories support versioning, secret flagging, and sub-category filtering. Although all of this is entirely optional for coders. If you ever want to add a new category and use it, all you need to do is make the barebones category datum and the define. I've kept existing procs such as log_game, and simply turned them into a wrapper for Logger.Log(xxx, ...) Makes processing and filtering logs much easier in the future, while only minimally downgrading log crawling experience. I am also working on a log viewer frontend for admin usage however that will take a little bit longer to finish up. Also makes special logging and data tracking much easier thanks to a data list processing implementation and handling :cl: server: All logs are now formatted in json, excluding perf and investigations /:cl: --------- Signed-off-by: GitHub <[email protected]> Co-authored-by: tattle <[email protected]> Co-authored-by: Kyle Spier-Swenson <[email protected]> Co-authored-by: GoldenAlpharex <[email protected]>
…e too (#75617)   I promised I would add it; and while it's not as nice as my previous iteration it is faster and more streamlined. :cl: admin: new log viewer, try it out. (View Round Logs) /:cl: Fixes #75605 --------- Co-authored-by: san7890 <[email protected]>
I'm not sure how this ever worked closes #75619  :cl: fix: Metalgen recipe generation works again /:cl:
This was referenced Jan 10, 2024
Closed
This was referenced Jan 12, 2024
This was referenced Jan 12, 2024
This was referenced Jan 12, 2024
Closed
This was referenced Jan 14, 2024
This was referenced Jan 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Why It's Good For The Game
Changelog
🆑
/:cl: