Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit tests for runtime/core - scope #94

Merged
merged 3 commits into from
Oct 11, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 69 additions & 0 deletions pkg/runtime/core/scope_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
package core_test

import (
"testing"

"github.com/MontFerret/ferret/pkg/runtime/core"
"github.com/MontFerret/ferret/pkg/runtime/values"
. "github.com/smartystreets/goconvey/convey"
)

func TestScope(t *testing.T) {
Convey("Should match", t, func() {
rs, cf := core.NewRootScope()
Copy link
Member

@ziflex ziflex Oct 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Let's do the final change.

RootScope - varA
Child1Scope - varB
Child2Scope - empty

Add a check that Child2Scope is able to get a variable from the root scope. (it will test functionality of scope traversing)

Copy link
Member

@ziflex ziflex Oct 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just add it as a 2nd Convey suit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the new TestScopeTraversing should cover this situation, let me know your thoughts :)


So(cf, ShouldNotBeNil)

s := core.NewScope(rs)

So(s.HasVariable("a"), ShouldBeFalse)

s.SetVariable("a", values.NewString("test"))

So(s.HasVariable("a"), ShouldBeTrue)

v, err := s.GetVariable("a")

So(err, ShouldBeNil)
So(v, ShouldEqual, "test")

c := s.Fork()

So(c.HasVariable("a"), ShouldBeTrue)

cv, err := c.GetVariable("a")

So(err, ShouldBeNil)
So(cv, ShouldEqual, "test")
})
}

func TestScopeTraversing(t *testing.T) {
Convey("Should match", t, func() {
rs, cf := core.NewRootScope()
So(cf, ShouldNotBeNil)

s := core.NewScope(rs)

rs.SetVariable("a", values.NewString("test"))
v, err := s.GetVariable("a")

// root traversal should work
So(err, ShouldBeNil)
So(v, ShouldEqual, "test")

s.SetVariable("b", values.NewString("test2"))
s2 := core.NewScope(rs)
_, err = s2.GetVariable("b")

// child traversal should fail
So(err, ShouldNotBeNil)

v2, err := s2.GetVariable("a")

// root traversal should work
So(err, ShouldBeNil)
So(v2, ShouldEqual, "test")

})
}