Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MP-1215 uv-related fixes for base images #20

Merged
merged 6 commits into from
Jan 10, 2025

Conversation

TimurDaukaevMoonvision
Copy link
Collaborator

@TimurDaukaevMoonvision TimurDaukaevMoonvision commented Jan 8, 2025

Description

There are some additional fixes for base images, which were not implemented before, because the corresponding issues were found only during the review of changes for child images:

  • environment.yml for uv Dockerfile has been entirely removed. Actually, this Dockerfile does not even use micromamba base image anymore, just a simple debian.
  • Since we are free from micromamba, we can use python base image instead, which gives us globally available python
  • We cannot install libnpp via conda now for moonbox images, so I'm doing this via apt. No idea, if that's an equivalent solution or not - but I don't know, what exactly to test.

How to test

  • docker pull moonvision/dev-python-base:uv-3.11-latest
  • docker run -it --rm moonvision/dev-python-base:uv-3.11-latest python
  • docker run -it --rm moonvision/dev-python-base:uv-3.11-latest uv run python

Both run commands should launch python

@TimurDaukaevMoonvision TimurDaukaevMoonvision self-assigned this Jan 8, 2025
@TimurDaukaevMoonvision TimurDaukaevMoonvision changed the title MP-1215 Entirely remove micromamba for uv MP-1215 uv-related fixes for base images Jan 8, 2025
@TimurDaukaevMoonvision TimurDaukaevMoonvision marked this pull request as ready for review January 9, 2025 09:48
@ahirner
Copy link
Member

ahirner commented Jan 9, 2025

We cannot install libnpp via conda now for moonbox images, so I'm doing this via apt

Seems like ffmpeg compiled well will that.
I test this and torch on GPU with some older cuda 11.8.

Copy link
Member

@ahirner ahirner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GPU tests successful 🐍 🦾

docker/python-base/DockerfileUV Outdated Show resolved Hide resolved
@TimurDaukaevMoonvision TimurDaukaevMoonvision merged commit 6f60a9a into master Jan 10, 2025
18 checks passed
@TimurDaukaevMoonvision TimurDaukaevMoonvision deleted the feature/MP-1215-uv-fixes branch January 10, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants