Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rendering after deleting playlist items #5

Merged
merged 1 commit into from
Sep 20, 2020
Merged

Fix rendering after deleting playlist items #5

merged 1 commit into from
Sep 20, 2020

Conversation

MoritzMaxeiner
Copy link
Owner

daneren2005#912 (comment)

Fixes daneren2005#910

The existing method of removing elements from playlist has 2 issues:

1. The removal by index ID from the storage list creates index mismatches.

2. The UI is not updated correctly and mismatches even further.

This patch users an iterator to correctly keep the data storage state correct and takes advantage of the data binding to the RecyclerView to only update the UI once and directly from the data, instead of pushing remove by index.

@MoritzMaxeiner MoritzMaxeiner merged commit 9e8b06f into MoritzMaxeiner:fork Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MoritzMaxeiner @vrih